<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>9725</bug_id>
          
          <creation_ts>2016-06-07 21:27:08 +0000</creation_ts>
          <short_desc>add docstrings to functions in lib/bb/utils.py that are used in meta- files.</short_desc>
          <delta_ts>2021-01-14 14:17:17 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>7</classification_id>
          <classification>Build System, Metadata &amp; Runtime</classification>
          <product>BitBake</product>
          <component>bitbake</component>
          <version>2.2</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard>NEWCOMER</status_whiteboard>
          <keywords></keywords>
          <priority>Medium</priority>
          <bug_severity>enhancement</bug_severity>
          <target_milestone>3.3</target_milestone>
          
          <blocked>9612</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="brian avery">brian.avery</reporter>
          <assigned_to>mshah</assigned_to>
          <cc>joshuagloe</cc>
    
    <cc>mshah</cc>
    
    <cc>poky.bs.watcher</cc>
    
    <cc>poky.watcher</cc>
    
    <cc>randy.macleod</cc>
    
    <cc>richard.purdie</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>No (bug/feature does not impact docs)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>62727</commentid>
    <comment_count>0</comment_count>
    <who name="brian avery">brian.avery</who>
    <bug_when>2016-06-07 21:27:08 +0000</bug_when>
    <thetext>a number of functions in lib/bb/utils.py are used throughout the meta*/ recipe and bbclass files. These need docstrings for programmers and so that we have a starting point for actual documentation.  Here&apos;s a not guaranteed comprehensive list of functions that are missing docstrings:
explode_dep_versions
explode_versions
vercmp*
prunedir
contains_any</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>86968</commentid>
    <comment_count>1</comment_count>
    <who name="Randy MacLeod">randy.macleod</who>
    <bug_when>2020-04-09 15:17:34 +0000</bug_when>
    <thetext>Robert, would you like to work on this?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>88833</commentid>
    <comment_count>2</comment_count>
    <who name="">mshah</who>
    <bug_when>2020-12-30 11:30:08 +0000</bug_when>
    <thetext>@brian @Randy
I&apos;ll be happy to work on this. 
I can see other functions as well which don&apos;t have docstrings. Should I add it to all remaining functions or anyone have a specific function list?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>88862</commentid>
    <comment_count>3</comment_count>
    <who name="Randy MacLeod">randy.macleod</who>
    <bug_when>2021-01-05 00:48:56 +0000</bug_when>
    <thetext>Milan, Thanks. Brian isn&apos;t involved in YP currently.
I&apos;d say start with a few and see if they get merged and the keep going as you see fit.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>88863</commentid>
    <comment_count>4</comment_count>
    <who name="">mshah</who>
    <bug_when>2021-01-05 05:18:20 +0000</bug_when>
    <thetext>Thanks, Randy. I&apos;ll take the bug and start working.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>88864</commentid>
    <comment_count>5</comment_count>
    <who name="">mshah</who>
    <bug_when>2021-01-05 06:13:05 +0000</bug_when>
    <thetext>I have gone through both Bug 9725 and Bug 9612 and found a list of functions.

Functions that already have a docstring.
- contains
- lockfile
- unlockfile
- explode_dep_versions2
- join_deps
- explode_deps
- mkdirheir
- copyfile

Functions that need a docstring.
- prunedir
- explode_dep_versions
- vercmp*
- contains_any</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>88907</commentid>
    <comment_count>6</comment_count>
    <who name="">mshah</who>
    <bug_when>2021-01-11 13:03:11 +0000</bug_when>
    <thetext>Hi @randy.macleod@windriver.com,

Patch is accepted and merged to master branch.
Ref:
https://git.openembedded.org/bitbake/commit/?id=b61ba4a18693a9e553d2a93161feb0bcc1c82384

I&apos;m marking the bug as resolved now.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>88916</commentid>
    <comment_count>7</comment_count>
    <who name="Richard Purdie">richard.purdie</who>
    <bug_when>2021-01-13 23:27:12 +0000</bug_when>
    <thetext>Looks good, thanks for the help on this!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>88922</commentid>
    <comment_count>8</comment_count>
    <who name="Randy MacLeod">randy.macleod</who>
    <bug_when>2021-01-14 14:17:17 +0000</bug_when>
    <thetext>Thanks Milan.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>