9876 2016-07-04 16:47:47 +0000 patchtest-oe: check that attached SW patches does not contain trailing spaces 2017-12-06 16:57:00 +0000 1 1 6 Yocto Project Subprojects Patchwork/Patchtest Patchtest 2.1 x86 Multiple RESOLVED FIXED Medium+ enhancement 2.2 M2 1 leonardo.sandoval.gonzalez jose.perez.carranza bluelightning richard.purdie --- --- No (bug/feature does not impact docs) oldest_to_newest 63635 0 leonardo.sandoval.gonzalez 2016-07-04 16:47:47 +0000 trailing spaces should not be present on sw patches, so do a check on these patches and fail if any of them has one or more. 63661 1 bluelightning 2016-07-06 02:15:19 +0000 I feel this goes a bit too far. The benefit of validating this is going to be negligible. 63669 2 leonardo.sandoval.gonzalez 2016-07-06 13:49:37 +0000 (In reply to comment #1) > I feel this goes a bit too far. The benefit of validating this is going to > be negligible. I understand your point; but why should git track blanks? The check is already implemented but for the moment is the todo folder. We may remove it later. 63687 3 bluelightning 2016-07-06 20:03:48 +0000 The point is if we're going to be rejecting people's patches we should be doing so for good reasons. I just don't think this one qualifies. 63691 4 leonardo.sandoval.gonzalez 2016-07-06 20:32:52 +0000 (In reply to comment #3) > The point is if we're going to be rejecting people's patches we should be > doing so for good reasons. I just don't think this one qualifies. I am following the first recommendation of this link: https://www.python.org/dev/peps/pep-0008/#other-recommendations As I said, right now the test does not hurt anyone, it is on the 'todo' checks. I can remove it anytime. 63789 5 jose.perez.carranza 2016-07-11 13:44:53 +0000 Patch already sent to Leonardo Sandoval Gonzalez