<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugzilla.yoctoproject.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugzilla.yoctoproject.org/"
          
          maintainer="it-coreprojects-helpdesk@linuxfoundation.org"
>

    <bug>
          <bug_id>9959</bug_id>
          
          <creation_ts>2016-07-15 21:12:16 +0000</creation_ts>
          <short_desc>patchtest-oe: the check for &apos;signed-off-by&apos; format is failing on unicode names</short_desc>
          <delta_ts>2017-12-06 17:03:53 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>6</classification_id>
          <classification>Yocto Project Subprojects</classification>
          <product>Patchwork/Patchtest</product>
          <component>Patchtest</component>
          <version>2.3</version>
          <rep_platform>x86</rep_platform>
          <op_sys>Multiple</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>Medium+</priority>
          <bug_severity>major</bug_severity>
          <target_milestone>2.2 M3</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Leonardo Sandoval Gonzalez">leonardo.sandoval.gonzalez</reporter>
          <assigned_to name="Daniela Plascencia">daniela.plascencia</assigned_to>
          <cc>sgw</cc>
          
          
          <cf_os>---</cf_os>
          <cf_regression_type>---</cf_regression_type>
          
          <cf_docchange>No (bug/feature does not impact docs)</cf_docchange>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>64069</commentid>
    <comment_count>0</comment_count>
    <who name="Leonardo Sandoval Gonzalez">leonardo.sandoval.gonzalez</who>
    <bug_when>2016-07-15 21:12:16 +0000</bug_when>
    <thetext>Current parser (pyparsing) is not parsing correctly those signed-off-by patches that contain unicode chars (like Aníbal Limón), thus giving false positives:

&gt; git pw mbox 337 | patchtest - --test-dir ~/repos/pt-oe/tests --no-apply --raw
----------------------------------------------------------------------
Ran 4 tests in 6.249s

OK
[[&quot;ID&quot;, &quot;mbox.signed_off_by.test_signed_off_by.SignedOffBy.test_signed_off_by_format&quot;], [&quot;line&quot;, &quot;Signed-off-by: An\u00edbal Lim\u00f3n &lt;anibal.limon@linux.intel.com&gt;&quot;], [&quot;column&quot;, 18]]
[[&quot;ID&quot;, &quot;mbox.subject.test_subject.Subject.test_subject_length&quot;], [&quot;Subject&quot;, &quot;utils/qemurunner.py: QemuRunner.start() add support for specify extra kernel cmdline&quot;], [&quot;Length&quot;, &quot;Current length 84 Max length 80&quot;]]

where .git/config contains

[patchwork &quot;default&quot;]
        url = http://patchwork.openembedded.org
        project = oe-core</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>65646</commentid>
    <comment_count>1</comment_count>
    <who name="Leonardo Sandoval Gonzalez">leonardo.sandoval.gonzalez</who>
    <bug_when>2016-08-31 14:58:56 +0000</bug_when>
    <thetext>Instead of using pyparsing, standard (regular expression) python module can be used.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>65922</commentid>
    <comment_count>2</comment_count>
    <who name="Daniela Plascencia">daniela.plascencia</who>
    <bug_when>2016-09-08 14:01:10 +0000</bug_when>
    <thetext>Using pyparsing regular expressions to fix this bug.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>