Bug 10370

Summary: selftest: test_invalid_recipe_src_uri fails to locate fetcher error
Product: [QA/Testing] Build Testing Reporter: Benjamin Esquivel <benjamin.esquivel>
Component: generalAssignee: Benjamin Esquivel <benjamin.esquivel>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: Medium+    
Version: unspecified   
Target Milestone: 2.2 M4   
Hardware: x86   
OS: Multiple   
Whiteboard:
OS type for building Yocto: --- Type of Regression: ---
Verified: Documentation change: No (bug/feature does not impact docs)
Attachments:
Description Flags
selftest error log
none
Autobuilder execution log for fix verification purposes none

Description Benjamin Esquivel 2016-10-04 17:34:14 UTC 
on commit fb71f34d7379569c23cc00e18d134093147613f5, test_invalid_recipe_src_uri is failing to locate the fetcher error for a negative check with a file://invalid.

See the attached error log.

Instructions to reproduce:

poky $ git checkout fb71f34d7379569c23cc00e18d134093147613f5
poky $ . ./oe-init-build-env
build $  oe-selftest -r bbtests.BitbakeTests.test_invalid_recipe_src_uri

Expected result: Test passes
Actual result: The test fails with an error:

AssertionError: None is not true : "invalid" file doesn't exist, yet fetcher didn't report any error.
Comment 1 Benjamin Esquivel 2016-10-04 17:35:50 UTC 
Created attachment 3451 [details]
selftest error log
Comment 2 Benjamin Esquivel 2016-10-04 17:45:48 UTC 
seems like updating the error grep fixes the test. Finding where the text output message changed to confirm this is the root cause.
Comment 3 Benjamin Esquivel 2016-10-04 19:47:48 UTC 
poky commit: 

4359ef08 base.bbclass: Use bb.fatal() instead of raising FuncFailed[1]

changed the way the fetcher error is reported.

Previous reporting:
...Function failed: Fetcher failure for URL:...

New reporting:
...Fetcher failure for URL:...

Other than the test update, it doesn't look like any other error to this particular bug must be fixed.

[1] http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=4359ef089566375ccc502f587cd3be670a2d67f0
Comment 4 Benjamin Esquivel 2016-10-04 20:01:19 UTC 
review posted at:

http://lists.openembedded.org/pipermail/openembedded-core/2016-October/127277.html
Comment 5 Benjamin Esquivel 2016-10-05 17:03:14 UTC 
Created attachment 3453 [details]
Autobuilder execution log for fix verification purposes

The test now passes as it should, verified in the autobuilder.