Bug 1102

Summary: FILESEXTRAPATHS should be : delimited
Product: [Build System, Metadata & Runtime] OE-Core Reporter: Darren Hart <dvhart>
Component: coreAssignee: Darren Hart <dvhart>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: Medium CC: meta.mr.watcher, meta.watcher, sgw
Version: unspecified   
Target Milestone: 1.1 M2   
Hardware: x86   
OS: Multiple   
Whiteboard: Patch sent to oe-core list (May 25 2011)
OS type for building Yocto: --- Type of Regression: ---
Verified: Documentation change: ---

Description Darren Hart 2011-05-25 13:26:12 UTC
Path variables are typically : delimited. White space is allowed in paths, so is not a good choice for separating paths. Currently utils.bbclass performs the following:

def base_set_filespath(path, d):
	filespath = []
	extrapaths = (bb.data.getVar("FILESEXTRAPATHS", d, True) or "").split()
	path = extrapaths + path
	# The ":" ensures we have an 'empty' override
	overrides = (bb.data.getVar("OVERRIDES", d, 1) or "") + ":"
	for p in path:
		for o in overrides.split(":"):
			filespath.append(os.path.join(p, o))
	return ":".join(filespath)

This splits FILESEXTRAPATHS on whitespace and then splits overrides on : and reassembles them all together as : delimited.

There is only one user of FILESEXTRAPATHS in oe-core (which uses : anyway), none in OE:

dvhart@doubt:~/source/oe.git
$ find . -name "*.bb*" | xargs grep FILESEXTRAPATHS
<EMPTY>

dvhart@doubt:~/source/oe-core.git
$ find . -name "*.bb*" | xargs grep FILESEXTRAPATHS
./meta/recipes-qt/qt4/qt4-tools-native_4.7.3.bb:FILESEXTRAPATHS =. "${FILE_DIRNAME}/qt-${PV}:"
./meta/classes/utils.bbclass:	extrapaths = (bb.data.getVar("FILESEXTRAPATHS", d, True) or "").split()

It should be acceptable to simply change the implementation.
Comment 1 Darren Hart 2011-05-25 22:09:29 UTC
Forgot to assign to me when I accepted.