Bug 11205

Summary: QA: Validate Reference kit supports whole disk encryption
Product: [QA/Testing] IoT Reference OS Kit Testing Reporter: Jair Gonzalez <jair.de.jesus.gonzalez.plascencia>
Component: intel-iot-refkit-automated-build-testingAssignee: Francisco Pedraza <francisco.j.pedraza.gonzalez>
Status: RESOLVED FIXED QA Contact: Jair Gonzalez <jair.de.jesus.gonzalez.plascencia>
Severity: enhancement    
Priority: Medium CC: patrick.ohly
Version: 2.3   
Target Milestone: 2.3 M4   
Hardware: x86   
OS: Multiple   
Whiteboard:
OS type for building Yocto: --- Type of Regression: ---
Verified: Documentation change: No (bug/feature does not impact docs)
Bug Depends on: 11070    
Bug Blocks:    

Description Jair Gonzalez 2017-03-21 23:28:21 UTC
Add test suite to validate Reference kit provides a mechanism based on whole-disk encryption to store data in a secure manner.
Comment 1 Patrick Ohly 2017-03-31 10:27:23 UTC
We need two kinds of tests: a) enough tests to merge the feature and b) additional feature that can be added later as time permits (open ended).

We agreed to treat this QA work items as a), i.e. they block the feature completion.

I don't know how QA wants to track part b). Filing issues is not particularly useful because of the open scope.

At this point, https://github.com/intel/intel-iot-refkit/pull/97 has one test which covers this functionality, which I consider good enough to close this issue once the PR is merged.
Comment 2 Francisco Pedraza 2017-04-03 19:52:58 UTC
(In reply to comment #1)
> We need two kinds of tests: a) enough tests to merge the feature and b)
> additional feature that can be added later as time permits (open ended).
> 
> We agreed to treat this QA work items as a), i.e. they block the feature
> completion.
> 
> I don't know how QA wants to track part b). Filing issues is not
> particularly useful because of the open scope.
> 
> At this point, https://github.com/intel/intel-iot-refkit/pull/97 has one
> test which covers this functionality, which I consider good enough to close
> this issue once the PR is merged.

Hi Patrick,
I have a question, so based on this can we close this bug? because it has one test that covers this funct. I am going to check how this test works and reply with feedback.
Comment 3 Patrick Ohly 2017-04-04 07:46:28 UTC
(In reply to comment #2)
> (In reply to comment #1)
> > At this point, https://github.com/intel/intel-iot-refkit/pull/97 has one
> > test which covers this functionality, which I consider good enough to close
> > this issue once the PR is merged.
> 
> I have a question, so based on this can we close this bug?

Once it is merged, yes (IMHO).

> because it has
> one test that covers this funct. I am going to check how this test works and
> reply with feedback.

Thanks.
Comment 4 Jair Gonzalez 2017-04-17 21:35:19 UTC
After an agreement with the Refkit team, the progress on the minimal required sanity tests to release a feature will be tracked on the same bug issue used to track the feature's development. Analogous QA bugs like this one may be created if required, and will be used to track the development of more extensive test cases.

According to this, the dependence will be inverted in relation to the feature bug.
Comment 5 Francisco Pedraza 2017-04-19 21:06:05 UTC
(In reply to comment #3)
> (In reply to comment #2)
> > (In reply to comment #1)
> > > At this point, https://github.com/intel/intel-iot-refkit/pull/97 has one
> > > test which covers this functionality, which I consider good enough to close
> > > this issue once the PR is merged.
> > 
> > I have a question, so based on this can we close this bug?
> 
> Once it is merged, yes (IMHO).
> 
> > because it has
> > one test that covers this funct. I am going to check how this test works and
> > reply with feedback.
> 
> Thanks.

Hi Patrick,
I am running this one in oe-selfetst
$ oe-selftest -r image-installer.ImageInstaller.test_install_no_tpm
I am planning to add one or two more for this implementation.
I have a suggestion. As a good practice would be good to add decorators to the test cases, in order to have more control when raising bugs and with test reports.
Comment 6 Patrick Ohly 2017-04-25 10:03:36 UTC
(In reply to comment #5)
> I have a suggestion. As a good practice would be good to add decorators to
> the test cases, in order to have more control when raising bugs and with
> test reports.

I'm not familiar with OEQA decorators. Feel free to improve the existing tests by adding that.
Comment 7 Francisco Pedraza 2017-05-23 19:50:47 UTC
I am going to close this bug due 
Trusted Platform Module (TPM), no TPM and fixed password are enough test scenarios for testing “disk encryption”.