| Summary: | poky-container: clarify that meta-data should be checked out using native tools that run the host and not with tools in container | ||
|---|---|---|---|
| Product: | [Yocto Project Subprojects] CROPS | Reporter: | Henry Bruce <henry.bruce> |
| Component: | crops-default | Assignee: | Tim Orling <tim.orling> |
| Status: | RESOLVED INVALID | QA Contact: | |
| Severity: | normal | ||
| Priority: | Medium | CC: | amber.n.elliot, brian.avery, javier.carrasco.cruz, pidge, randy.macleod, stephano, tim.orling, tvgamblin |
| Version: | 2.1.2 | ||
| Target Milestone: | 5.1 | ||
| Hardware: | x86 | ||
| OS: | Multiple | ||
| Whiteboard: | |||
| OS type for building Yocto: | --- | Type of Regression: | --- |
| Verified: | Documentation change: | Yes (doc changes required) | |
| Bug Depends on: | |||
| Bug Blocks: | 11097 | ||
|
Description
Henry Bruce
2017-04-19 18:04:29 UTC
As shown by initial comment it is not obvious for developers new to containers that the poky-container should *not* be used to obtain the meta-data, but just to build it. Docs at https://github.com/crops/poky-container/blob/master/README.md should be update accordingly. Moving to M3 to m4 Moving to Joshua seems like this should be the documentation bug for the solution in Bug 11097's comments. Build move to 5.0 -- ../Randy It has been addressed, and a fix has been suggested: https://github.com/crops/poky-container/pull/104 Does not seem to be merged yet. (In reply to Randy MacLeod from comment #7) > Does not seem to be merged yet. No, it has not been reviewed yet either. Apparently, the CROPS project has a very limited amount of reviewers. The PR will stay open, though. This bug is not exactly correct. The problem is if the workspace has not been created before launching the container (and properly passed in as a volume). This is documented in the README and the wiki (for Windows and MacOS). See example of fully functional cloning of metadata in: https://github.com/crops/poky-container/pull/104#discussion_r1613742020 While this could perhaps be better clarified in the README, the statement that it MUST be done outside of the container is false. It is only conditionally true when the user did not first create the workspace and pass in the volume, per the instructions. Perhaps the real issue here is 'repo' tool. The way to fix that is to create a derivative container with 'repo' added to it. This was rejected for the mainstream container because not everyone needs 'repo' tool. See https://github.com/crops/yocto-dockerfiles/pull/42 for discussion about git-lfs and repo tool and why they are not going to be added to the maintstream poky-container. Dockerfile.repo: FROM crops/poky:ubuntu-18.04 USER root RUN wget https://storage.googleapis.com/git-repo-downloads/repo -O /usr/local/bin/repo && \ chmod +x /usr/local/bin/repo # We always need to return to the usersetup and ENTRYPOINT USER usersetup ENV LANG=en_US.UTF-8 ENTRYPOINT ["/usr/bin/distro-entry.sh", "/usr/bin/dumb-init", "--", "/usr/bin/poky-entry.py"] Build: docker build -t crops/poky-repo:ubuntu-18.04 -f ./Docker.repo . Execution: ttorling@chiron:/srv/build/ttorling$ docker run --rm -it -v /srv/build/ttorling/crops-workspace:/workdir crops/poky-repo:ubuntu-18.04 --workdir=/workdir pokyuser@aa90fb6f937a:/workdir$ which repo /usr/local/bin/repo pokyuser@aa90fb6f937a:/workdir$ repo --help usage: repo COMMAND [ARGS] repo is not yet installed. Use "repo init" to install it here. The most commonly used repo commands are: init Install repo in the current working directory help Display detailed help on a command For access to the full online help, install repo ("repo init"). Bug reports: https://issues.gerritcodereview.com/issues/new?component=1370071 Because `repo` will always try to "phone home" and update itself, you will likely need to rebuild this container from time to time to have the latest version and avoid warnings. Should this ticket be closed? Maybe updated to restrict it to a better clarification in the README as stated in comment 9? Javier, Assigning to Tim and putting in NEEDINFO. I made significant comments on the pull request and do not believe this is valid. https://github.com/crops/poky-container/pull/104 |