| Summary: |
get_last_build_id not called correctly |
| Product: |
[Build System, Metadata & Runtime] Toaster
|
Reporter: |
David Reyna <david.reyna> |
| Component: |
toaster | Assignee: |
David Reyna <david.reyna> |
| Status: |
RESOLVED
FIXED
|
QA Contact: |
Libertad <libertad.gonzalez.de.la.cruz> |
| Severity: |
normal
|
|
|
| Priority: |
Medium
|
CC: |
jessica.zhang, stanciux.mihail
|
| Version: |
2.3 | |
|
| Target Milestone: |
2.4 M1 | |
|
| Hardware: |
x86 | |
|
| OS: |
Multiple | |
|
| Whiteboard: |
|
|
OS type for building Yocto:
|
---
|
Type of Regression:
|
---
|
|---|
|
Verified:
|
|
Documentation change:
|
No (bug/feature does not impact docs)
|
|---|
The method "get_last_build_id" is misused in several instances where the "()" is missing. While this is wrong it has not been crashing the code with Django 1.8. However, it does intermittently crash with Django 1.9. Here is an example problem and fix (toastergui/models.py): def get_last_outcome(self): - build_id = self.get_last_build_id + build_id = self.get_last_build_id() if (-1 == build_id): return( "" ) Observe that by assigning the function itself to "build_id" that will never be equal to -1.