Bug 12383

Summary: qemu inclusion of kernel modules is inconsistent.
Product: [Build System, Metadata & Runtime] OE-Core Reporter: brian avery <brian.avery>
Component: coreAssignee: Maxin B. John <maxin.john>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: Medium+ CC: california.l.sullivan, maxin.john, meta.mr.watcher, meta.watcher, randy.macleod, ross.burton, todor.minchev
Version: 2.4   
Target Milestone: 2.6 M3   
Hardware: x86   
OS: Multiple   
Whiteboard:
OS type for building Yocto: --- Type of Regression: ---
Verified: Documentation change: Yes (doc changes required)

Description brian avery 2017-11-27 19:08:14 UTC 
qemumips and qemumips64 both have the line
MACHINE_EXTRA_RRECOMMENDS = " kernel-modules"  

genericx86* pulls this in by including x86-base.inc.

Unfortunately, the other qemu machiens, including x86*, fail to pull the kernel modules into the image.  If you are trying to test something that relies on them, and have specifically built core-image-base or core-image-sato in order to make sure they are there; that would cause a great deal of confusion.

The inclusion of kernel-modules should be consistent. My vote would be to add the 
MACHINE_EXTRA_RRECOMMENDS = " kernel-modules" 
across the board.
Comment 1 brian avery 2017-11-27 19:08:43 UTC 
+cal,todor
Comment 2 Ross Burton 2017-11-30 16:16:58 UTC 
I think Randy changed the milestone by mistake
Comment 3 Randy MacLeod 2017-11-30 16:56:40 UTC 
Indeed. Thanks for catching that Ross.
Comment 4 Maxin B. John 2018-04-22 09:50:08 UTC 
patch sent to oe-core mailing list:
http://lists.openembedded.org/pipermail/openembedded-core/2018-April/150098.html
Comment 5 Ross Burton 2018-05-10 08:28:41 UTC 
Richard feels that adding kernel-modules isn't the best idea as it would hide kernel module dependencies.

So:
1) use git blame to identify if there is a good reason qemumips pulls in every module by recommending kernel-modules, and if it is for a specific module then make that a recommends or depends as appropriate
2) Remove kernel-module from recommends and verify images still work.