Bug 12728

Created attachment 4295 [details]
Patch that allows for earlier failure message.

A caught exception in runfectcmd is assumed to always be benign when it is not.

Before this fix it is assumed that the removal of the
remote can only fail because there is not remote to remove. This
is a false assumption. Example error which would be ignored:
    
git -c core.fsyncobjectfiles=0 remote rm origin failed with exit code 1, output:
Note: A branch outside the refs/remotes/ hierarchy was not removed;
to delete it, use:
git branch -d master
error: could not lock config file config
error: Could not remove config section 'remote.origin'

Due to the masking of this error a stranger error will be
presented to the user, because this time we do not mask the
exception:
    
git -c core.fsyncobjectfiles=0 remote add --mirror=fetch origin https://github.com/ptsneves/tl-wn722.git failed with exit code 128, output:
fatal: remote origin already exists.
    
The most likely reason that the remote cannot be removed nor
modified is that the DL_DIR/git2 does not have write permissions
compatible with the user running bitbake.

This happened to me while pointing to a pre-populated download directory. The patch below allowed me to see the true nature of the problems I was facing.