Bug 12813

Summary:	[QA 2.6 M1 rc1 ][Toaster]:Build stopped without error, to terminate by ctrl+c
Product:	[Build System, Metadata & Runtime] Toaster	Reporter:	nagarajagopal <nagarajagopalx.velu>
Component:	toaster	Assignee:	David Reyna <david.reyna>
Status:	RESOLVED FIXED	QA Contact:	Toaster default assignee <toaster>
Severity:	normal
Priority:	Medium	CC:	jessica.zhang, sharmasudhir, stanciux.mihail
Version:	2.6
Target Milestone:	2.6 M4
Hardware:	x86
OS:	Multiple
Whiteboard:
OS type for building Yocto:	---	Type of Regression:	---
Verified:		Documentation change:	No (bug/feature does not impact docs)

Description nagarajagopal 2018-06-25 10:15:33 UTC

STATUS - FAILED
 BUILD: 2.6_M1.rc1 - ddbd7b0cd6580ee26e11aa87e426fb294b372d64
 ENVIRONMENT - Ubuntu 16.04

 STEPS TO REPRODUCE,
 - run "source toaster start"
 - run "bitbake core-image-minimal"
 - terminate the build by ctrl+c 

 ACTUAL RESULT:
 Build is stopped without error.
 
 EXPECTED RESULT:
 Build should stop with error and failed as per test cases.

 REGRESSION: 
 Regression done with 2.5, Build is stopped without error.

Comment 1 David Reyna 2018-06-25 10:18:05 UTC

Hi, I am not familiar with this test case.

What is the expected error?

Comment 2 nagarajagopal 2018-06-26 08:52:02 UTC

Hi David,

On terminating the build by ctrl+c, a number of errors and warnings should be thrown by the build in 'All builds' page, 'Latest builds' section and 'Build dashboard' page with details.

The details of the test case is available at:
https://bugzilla.yoctoproject.org/tr_show_case.cgi?case_id=951

Comment 3 David Reyna 2018-06-27 17:35:40 UTC

Thank you for the clarification, I have scheduled this fix.

Comment 4 David Reyna 2018-09-30 09:23:22 UTC

I observe the following:

1. If I start a command line build and stop it with a single or double CTRL+C, the build log shows the massage "Build cancelled", which is the expected and desired result.

2. If I start a command line build and build for example the false target "bitbake foobar", the build fails but there is no error count in the GUI, though the downloadable log does contain the error. This appears to be the failing behavior.

3. In contrast, if I start a build in the Toaster GUI and build for example the false target "foobar", the build fails and there _is_ an error count and link. This is the intended behavior.

The root cause of the error is that in "buildinfohelper.py", the method store_log_event would always put log messages for CLI builds in the backlog, but there was no way to get them out. The solution is in the "close" method force all CLI events to be registered.

NOTE: we should update the test case to use a false build target as a 'failure' build test.

Comment 5 David Reyna 2018-10-16 19:03:38 UTC

(Bitbake rev: 6458cc4234337f551dfe189b6f8800d8da886c24)

Comment 6 Sudhir Sharma 2018-11-09 06:30:04 UTC

Issue is resolved.