Bug 12904

https://www.kernel.org/doc/Documentation/ABI/testing/sysfs-class-power

Also prior art in upower's up-device-supply.c in https://cgit.freedesktop.org/upower/tree/src/linux

Hi @ross@burtonini.com

I'm interested and want to work on this bug. But I need little guidance.

Are we planning to remove libacpi from meta/recipes-bsp/ and add upower package in oe-core?

If my understanding is incorrect then please provide some information so I could start.

Thanks,
Milan Shah

As the battery applet is already modular, I'd suggest we should start with a new sysfs backend and potentially also add an upower backend too.

But starting with sysfs.

Assigning to Milan and moving into 3.4. If you need more help getting started just ask! Thanks Milan. ../Randy

Thanks, @Randy MacLeod for assigning it to me and Yes I need some help here.

I understood that we need sysfs support to monitor the battery levels. As I see in kernel-doc (mentioned in the comment) that we have support in the kernel,

* Do I need to add kernel config for core-image-sato which enables them?
or
* Do I need to backport any patch from the newer kernel version to the existing one?
or
* Is that something else that I still don't know?


Thanks,
Milan Shah

Assume that sysfs is supported, as it will be in most builds.

Another good document to understand power_supply in kernel.

https://www.kernel.org/doc/Documentation/power/power_supply_class.txt

Build move to 5.0 -- ../Randy

Hi Randy 

Can you please confirm if anything need to be done ?

Thanks
Sanjay :)

This still needs to be done.

Thanks Ross for confirmation i would like to work on this.

Thanks!

Bulk move of 5.0 medium importance issues to 5.99.
Move to 5.1 if you want to actively work on an issue.

Move to 5.99 since no one is actively working on this issue.
Move to 5.x if you start on a task, please.

Hi Ross, Randy,

I have understood the ask thoroughly and would like to work on this. Can this be assigned to me if nobody is working on this actively?

Regards,
Dixit

With pleasure!

Hi Ross,

I have submitted the patches.

Hi Ross,
I have submitted the patches for the matchbox-panel-2 changes for the subject. Kindly have a look.

Also, The sysfs mechanism is controlled by the existing compilation option --with-battery="sysfs" (same as existing acpi option). That change will fall in the recipe file https://layers.openembedded.org/layerindex/recipe/655/
How should we take that change?

Thanks,
Dixit

Submitted final patch for review https://lists.yoctoproject.org/g/yocto-patches/topic/109447061#msg859

Hi randy.macleod@windriver.com, ross.burton@arm.com,

Kindly review the final patch submitted to the mailing list.

Hello Randy, Ross,
I would really appreciate reviews on last submitted patch. https://lists.yoctoproject.org/g/yocto-patches/topic/109447061

I am more than excited to get this going as this is my first contribution at YP.

Dixit, 

Ross provided some comments.
You can either fix the issues that he identified and submit a v2 or
reply to that thread and discuss his suggestions.

Ross is on holiday today, fyi.

Let me know if this gets stuck again.

Add Ross since I don't see Dixit's commit in:

https://git.yoctoproject.org/matchbox-panel-2/log/

(In reply to Randy MacLeod from comment #24)
> Add Ross since I don't see Dixit's commit in:
> 
> https://git.yoctoproject.org/matchbox-panel-2/log/

Hi Randy,

The changes are still in review, the latest patches are of v7 :) - https://lists.yoctoproject.org/g/yocto-patches/message/2178

Will the changes show up in the matchbox-panel-2/log untill it gets reviewed & accepted by Ross?

Thanks,
Dixit

Ross please review the patches early in 6.2.

Dixit, sorry for the delay, this time Ross promises to follow-up!