| Summary: | _remove does not work when the item to be removed contains variables | ||
|---|---|---|---|
| Product: | [Build System, Metadata & Runtime] BitBake | Reporter: | Alexander Kanavin <alex.kanavin> |
| Component: | bitbake | Assignee: | Richard Purdie <richard.purdie> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | Medium+ | CC: | erik.boto, openatv, poky.bs.watcher, poky.watcher |
| Version: | unspecified | ||
| Target Milestone: | 2.6 M4 | ||
| Hardware: | x86 | ||
| OS: | Multiple | ||
| Whiteboard: | |||
| OS type for building Yocto: | --- | Type of Regression: | --- |
| Verified: | Documentation change: | No (bug/feature does not impact docs) | |
I'm a bit puzzled by this as I can't get it to reproduce for me. I only had openssl 1.1.1 available so I tweaked:
-RDEPENDS_${PN}-ptest += "perl-module-file-spec-functions bash python"
+RDEPENDS_${PN}-ptest += "perl-module-file-spec-functions bash python ${PN}-misc"
and was then adding or removing:
RDEPENDS_${PN}-ptest_remove = "${PN}-misc"
$ bitbake openssl -e | egrep BASEHASH.*do_package=\|^RDEPENDS_.*ptest=
BB_BASEHASH_task-do_package="5b6024c21bda4980f65a5deffd5e9f61"
RDEPENDS_openssl-ptest=" perl-module-file-spec-functions bash python openssl-misc"
$ bitbake openssl -e | egrep BASEHASH.*do_package=\|^RDEPENDS_.*ptest=
BB_BASEHASH_task-do_package="452b08f55a52830fa97efab8ac473cb8"
RDEPENDS_openssl-ptest="perl-module-file-spec-functions bash python"
and RDEPENDS changes as expected, as does the BASEHASH. If the hash of the task changes, it should rebuild (repackage in this case).
Given that, is there more info you can give to reproduce this? Was this with master or one of the stable branches?
I was able to reproduce but not consistently, something very odd is going on :( There were two issues, one was whitespace being squashed by any _remove operator, active or inactive. The other was _remove operators not being cached correctly. I've sent patches for both. The fix: http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=f7f5e30667e1ad8e1ca76ee331be2843f2976bfa Some extra tests: http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=4ef016683d986cc5291e494789ff5a49b28030eb The fix for the whitespace issue: http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=a9aa1d24c7c4518173f622a1fab55a98a16150f9 |
E.g. like this: RDEPENDS_${PN}-ptest = "${PN}-misc make perl perl-module-filehandle bc" # Uncommenting either of these lines does not trigger a re-packaging, even though it should! #RDEPENDS_${PN}-ptest_remove = "${PN}-misc" #RDEPENDS_${PN}-ptest_remove = "openssl-misc" Reproducer here: http://git.yoctoproject.org/cgit.cgi/poky-contrib/commit/?h=akanavin/_remove-issue&id=82e1a90765024ec7184803cbab9267f38dcf532d