Bug 13107

Summary: oldnoconfig has been removed in 4.20+ kernel
Product: [Build System, Metadata & Runtime] OE-Core Reporter: Robert Berger <pokylinux>
Component: kernelAssignee: Armin Kuster <akuster>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: Medium CC: tom.zanussi
Version: 2.6   
Target Milestone: 2.6.2   
Hardware: x86   
OS: Multiple   
Whiteboard: Backport to 2.6.2
OS type for building Yocto: --- Type of Regression: ---
Verified: Documentation change: Don't know

Description Robert Berger 2018-12-27 15:25:22 UTC
ERROR: linux-yocto-custom-4.20-custom-ml-debug+gitAUTOINC+8fe28cb58b-r0 do_configure: Function failed: do_configure (log file is located at /tmp/yocto-autobuil
der/yocto-autobuilder/yocto-worker/res-custom-thud-multi-v7-core-image-minimal/build/build/tmp/work/multi_v7_ml-poky-linux-gnueabi/linux-yocto-custom/4.20-cust
om-ml-debug+gitAUTOINC+8fe28cb58b-r0/temp/log.do_configure.25282)
ERROR: Logfile of failure stored in: /tmp/yocto-autobuilder/yocto-autobuilder/yocto-worker/res-custom-thud-multi-v7-core-image-minimal/build/build/tmp/work/mul
ti_v7_ml-poky-linux-gnueabi/linux-yocto-custom/4.20-custom-ml-debug+gitAUTOINC+8fe28cb58b-r0/temp/log.do_configure.25282
Log data follows:
| DEBUG: Executing python function check_oldest_kernel
| DEBUG: Python function check_oldest_kernel finished
| DEBUG: Executing shell function do_configure
...
ERROR: linux-yocto-custom-4.20-custom-ml-debug+gitAUTOINC+8fe28cb58b-r0 do_configure: Function failed: do_configure (log file is located at /tmp/yocto-autobuil
der/yocto-autobuilder/yocto-worker/res-custom-thud-multi-v7-core-image-minimal/build/build/tmp/work/multi_v7_ml-poky-linux-gnueabi/linux-yocto-custom/4.20-cust
om-ml-debug+gitAUTOINC+8fe28cb58b-r0/temp/log.do_configure.25282)
ERROR: Logfile of failure stored in: /tmp/yocto-autobuilder/yocto-autobuilder/yocto-worker/res-custom-thud-multi-v7-core-image-minimal/build/build/tmp/work/mul
ti_v7_ml-poky-linux-gnueabi/linux-yocto-custom/4.20-custom-ml-debug+gitAUTOINC+8fe28cb58b-r0/temp/log.do_configure.25282
Log data follows:
| DEBUG: Executing python function check_oldest_kernel
| DEBUG: Python function check_oldest_kernel finished
| DEBUG: Executing shell function do_configure

As upstream kernel commit 312ee68752fa ("kconfig: announce removal of oldnoconfig if used") announced, it is time for the removal.[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=04c459d204484fa4747d29c24f00df11fe6334d4

... but we still use it in the kernel recipe[2]

https://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/classes/kernel.bbclass?h=master-next#n495

I just replaced oldnoconfig with olddefconfig as was proposed, but rejected here[3]

[3] https://patchwork.openembedded.org/patch/86505/

What's the proper solution for 4.20+ kernels?
Comment 1 Bruce Ashfield 2018-12-28 15:01:05 UTC
There's nothing wrong with the patch I submitted, its intention was to get it into tree before 4.20 came along.

I'll resubmit the change shortly.
Comment 2 Bruce Ashfield 2018-12-28 15:13:11 UTC
actually, looking at this more. My patch did make it into the kernel class in October.

We still must keep the fallback option for compatibility reasons, but you should never be making it to the || part of that configuration clause.

How exactly is the olddefconfig failing with your kernel and hence you are running the oldnoconfig ?

Bruce

----------------


commit d2aaa2614a6edf5386fd9f3a68cc3ff899a3274a
Author: Bruce Ashfield <bruce.ashfield@windriver.com>
Date:   Tue Oct 30 15:04:26 2018 -0400

    kernel: use olddefconfig as the primary target for KERNEL_CONFIG_COMMAND
    
    As was warned by commit 312ee68752fa [kconfig: announce removal of
    oldnoconfig if used], oldnoconfig has been removed from the 4.20 kernel.
    
    So we switch our default mode to olddefconfig.
    
    commit fb16d8912 [kconfig: replace 'oldnoconfig' with 'olddefconfig',
    and keep the old name as an alias] introduced olddefconfig in the 3.10
    kernel, we shuffle oldnoconfig to the fallback target.
    
    The fallback mode allows kernels between 3.10 and the currently listed
    oldest kernel of 3.2 to continue to configure.
    
    (From OE-Core rev: 8593dcb7e8c938530ff00ffedf7f3d02d26c3bad)
    
    Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>
    Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Comment 3 Robert Berger 2018-12-28 15:50:54 UTC
Hi Bruce,

I am not on poky master, but on some thud branch.

This is my poky branch:

https://github.com/RobertBerger/poky/tree/2018-11-28-thud-2.6+

This is my commit, which made 4.20 work - skipping backwards compatibility

https://github.com/RobertBerger/poky/commit/e0a8f45152b60c9edf6ba81c291118834203b3a8

Maybe I am missing something from master?

With this poky branch plus this 4.20 kernel 

https://github.com/RobertBerger/meta-mainline/blob/thud-training-v4.14.x/multi-v7-ml/recipes-kernel/linux/linux-yocto-custom_4.20.0.bb

I have the problem.
Comment 4 Bruce Ashfield 2018-12-31 03:22:54 UTC
You definitely need the patch that I referenced to build a 4.20+ kernel, which is why I sent it to the list in the fall. I was already building -dev kernels that were running into the problem.

That commit is only in master and would need to be backported to thud to support a 4.20+ kernel.
Comment 5 Stephen K Jolley 2019-01-11 17:32:06 UTC
Backport to 2.6.1 or 2.6.2
Comment 6 Armin Kuster 2019-01-11 17:44:34 UTC
(In reply to comment #5)
> Backport to 2.6.1 or 2.6.2

2.6.2 now.
Comment 9 Armin Kuster 2019-03-11 04:50:14 UTC
closing