Bug 13168

Summary: devtool: cannot add new recipe if reproducible_build class is inherited
Product: [Build System, Metadata & Runtime] OE-Core Reporter: Romuald Jeanne <romuald.jeanne>
Component: devtools / tool chainAssignee: Paul Eggleton <bluelightning>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: Medium+ CC: meta.mr.watcher, meta.watcher
Version: 2.6.2   
Target Milestone: 2.8 M2   
Hardware: All   
OS: Multiple   
Whiteboard: Backport 2.5 and 2.6
OS type for building Yocto: --- Type of Regression: ---
Verified: Documentation change: Don't know

Description Romuald Jeanne 2019-02-04 14:00:43 UTC 
Preconditions/Environment
-------------------------
Setup default Yocto configuration on THUD release:
DISTRO=nodistro
MACHINE=(any machine)

Add in 'local.conf' file
INHERIT += "reproducible_build"

Triggering Action/Cause
-----------------------
Once bitbake environment enabled, run devtool command to add a new recipe:
devtool add godot https://github.com/godotengine/godot

Expectation
-----------
The devtool command should successfully donwload source code and create a recipe
skeleton.

Actual Result
-------------
The devtool command ends with error:
ERROR: Command 'script -e -q -c "recipetool --color=always create --devtool -o /tmp/devtoolpessb4ed 'https://github.com/godotengine/godot'  -x /home/yocto-thud/build/workspace/sources/devtoolsrcko5unxkk -N godot" /dev/null' failed

Reproducibility
---------------
1/1

Pre-Analysis:
-------------
With 'reproducible_build' class, it appears that new folder 'source-date-epoch' (cf. SDE_DIR) is not yet properly handled by 'create.py' script.
In this script, line 507, a filtering is done like this:
  filterout = ['git.indirectionsymlink']
While it should be:
  filterout = ['git.indirectionsymlink', 'source-date-epoch']
Such modification makes 'devtool add' command successful, but the 'source-date-epoch' folder can be redefined to other value...
Comment 1 Paul Eggleton 2019-07-01 21:00:09 UTC 
I cannot reproduce this with thud or master - devtool add succeeds every time. Is there possibly a missing step in your instructions? Some configuration missing perhaps? Is it still reproducible with current thud?
Comment 2 Romuald Jeanne 2019-07-02 09:15:19 UTC 
You're right.
Since 'recipetool: fix unbound variable when fixed SRCREV can't be found' commit has been merged in thud branch, there is no more issue.
Thanks.
Comment 3 Paul Eggleton 2019-07-04 04:06:15 UTC 
OK - this is the commit:

http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=568f0ab886cbcf83fcd9f154886280a7881d30fe

I can't quite see the connection at the moment, but we'll mark it as fixed.