Bug 13275

Summary: Wic kickstart file parameter --use-label not generating fstab entry
Product: [Build System, Metadata & Runtime] OE-Core Reporter: Jacopo Dall'Aglio <jacopo.dallaglio>
Component: Scripts and ToolsAssignee: Armin Kuster <akuster>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: Medium+ CC: diego.ml, randy.macleod, ross.burton
Version: 2.6.1   
Target Milestone: 2.6.4   
Hardware: x86   
OS: Multiple   
Whiteboard:
OS type for building Yocto: --- Type of Regression: ---
Verified: Documentation change: No (bug/feature does not impact docs)

Description Jacopo Dall'Aglio 2019-04-09 16:17:29 UTC
After creating an updated Yocto build environment:

    git clone git://git.yoctoproject.org/poky
    git checkout tags/yocto-2.6.1 -b test-wic-uselabel

    git branch -vv
        master            8217b47 [origin/master] gtk+: update for new catalog path
        * test-wic-uselabel 1cab405 build-appliance-image: Update to thud head revision

building core-image-minimal with standard conf file, adding IMAGE_FSTYPES += " wic" in core-image-minimal.bb,

    bitbake core-image-minimal

        Build Configuration:
        BB_VERSION           = "1.40.0"
        BUILD_SYS            = "x86_64-linux"
        NATIVELSBSTRING      = "universal"
        TARGET_SYS           = "i586-poky-linux"
        MACHINE              = "qemux86"
        DISTRO               = "poky"
        DISTRO_VERSION       = "2.6.1"
        TUNE_FEATURES        = "m32 i586"
        TARGET_FPU           = ""
        meta
        meta-poky
        meta-yocto-bsp       = "test-wic-uselabel:1cab405d88149fd63322a867c6adb4a80ba68db3"

and using the following wic kickstart files to build the image:

    ==> common.wks.inc <==
        # This file is included into 3 canned wks files from this directory
        part /boot --source bootimg-pcbios --ondisk sda --label boot --active --align 1024
        part / --source rootfs --use-uuid --fstype=ext4 --label platform --align 1024

    ==> qemux86-directdisk.wks <==
        # short-description: Create a qemu machine 'pcbios' direct disk image
        # long-description: Creates a partitioned legacy BIOS disk image that the user
        # can directly use to boot a qemu machine.

        include common.wks.inc

        bootloader  --timeout=0  --append="vga=0 rw oprofile.timer=1 rootfstype=ext4 "

the output of wic ls $BUILD_DIR/tmp/deploy/images/qemux86/core-image-minimal-qemux86.wic:

    Num     Start        End          Size      Fstype
    1       1048576     25477119     24428544  fat16
    2      26214400     51097599     24883200  ext4


The resulting partition table is:

    # stock fstab - you probably want to override this with a machine specific one

    /dev/root            /                    auto       defaults              1  1
    proc                 /proc                proc       defaults              0  0
    devpts               /dev/pts             devpts     mode=0620,gid=5       0  0
    tmpfs                /run                 tmpfs      mode=0755,nodev,nosuid,strictatime 0  0
    tmpfs                /var/volatile        tmpfs      defaults              0  0

    # uncomment this if your device has a SD/MMC/Transflash slot
    #/dev/mmcblk0p1       /media/card          auto       defaults,sync,noauto  0  0


When adding a new partition in the kickstart file, partition parameter --use-label should tell the wic plugin to take the --label value and use it to decide which partition in the partition table is going to be mounted at the specified mountpoint.
So let's add an empty partition labelled "test" at mountpoint "/test" placing the following line into qemux86-directdisk.wks.

    part /test --size 100 --fstype=ext4 --label test --use-label --align 1024

Output of wic ls shows that the new partition has been created:

    Num     Start        End          Size      Fstype
    1       1048576     25477119     24428544  fat16
    2      26214400     51097599     24883200  ext4
    3      51380224    156237823    104857600  ext4

But /etc/fstab has not changed:

    # stock fstab - you probably want to override this with a machine specific one

    /dev/root            /                    auto       defaults              1  1
    proc                 /proc                proc       defaults              0  0
    devpts               /dev/pts             devpts     mode=0620,gid=5       0  0
    tmpfs                /run                 tmpfs      mode=0755,nodev,nosuid,strictatime 0  0
    tmpfs                /var/volatile        tmpfs      defaults              0  0

    # uncomment this if your device has a SD/MMC/Transflash slot
    #/dev/mmcblk0p1       /media/card          auto       defaults,sync,noauto  0  0
    
I wasn't able to find a workaround without manually updating the fstab file in the image recipe.
Comment 1 Armin Kuster 2019-10-13 19:22:04 UTC
this appears to be 2.6.1 and we have had a few wic changes..

please try latest thud.

if it still fails, then Master needs to be check as I don't seen any "new" changes that may help with issue.
Comment 2 Armin Kuster 2019-11-14 15:44:55 UTC
I will mark this as addressed.
Comment 3 Armin Kuster 2019-11-14 15:45:08 UTC
closing