| Summary: | Meson detects googletest installed on system | ||
|---|---|---|---|
| Product: | [Build System, Metadata & Runtime] OE-Core | Reporter: | Martin <marejde> |
| Component: | devtools / tool chain | Assignee: | Ross Burton <ross.burton> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | Medium | CC: | alex.kanavin, meta.mr.watcher, meta.watcher, randy.macleod, ross.burton, sgw, tgamblin |
| Version: | unspecified | ||
| Target Milestone: | Future | ||
| Hardware: | x86 | ||
| OS: | Multiple | ||
| Whiteboard: | backport 3.1 | ||
| OS type for building Yocto: | --- | Type of Regression: | --- |
| Verified: | Documentation change: | Don't know | |
|
Description
Martin
2019-09-10 08:29:59 UTC
I'd say: 1) Change the self.src_dirs assignment to [] in our recipe 2) File upstream bug, maybe use $prefix instead of /usr? I am reluctant to make patches or submit bug reports for something I cannot reproduce. I'd suggest the original submitter should create and send a patch, and report the issue upstream, or at least share a recipe where the issue can be observed. (In reply to comment #1) > I'd say: > 1) Change the self.src_dirs assignment to [] in our recipe > 2) File upstream bug, maybe use $prefix instead of /usr? Thank you Ross, I sent a patch for using sys.prefix here https://github.com/mesonbuild/meson/pull/5919 . Should do the right thing when building in Yocto or with a Yocto generated SDK, I think. (In reply to comment #2) > I am reluctant to make patches or submit bug reports for something I cannot > reproduce. I'd suggest the original submitter should create and send a > patch, and report the issue upstream, or at least share a recipe where the > issue can be observed. Any component built with meson that has gtest as a dep in meson.build and does not have it as a dependency in its recipe should be a problem when building on a system that installs gtest source in /usr/src. Posted a comment in upstream pr about whether it makes sense for Meson or if it is something that needs to be patched in Yocto. Hongxu is no longer working on YP so unassign defect. Hongxu, I'd like to see this fix sooner than M4 so I've moved it to M2. Bulk move to 4.3 M3. Moved to M4. It appears that the request to patch upstream meson was denied according to the pull request against the Meson Source. So a patch should be created for the YP Meson recipe. @martin, can you provide a reproducer? It would be required to correctly test the patch. I just filed a new bug with meson to prod this further: https://github.com/mesonbuild/meson/issues/12690. Moved out of NEEDINFO Posted 'meson: don't look on the host for GTest when cross-compiling' to the list. Merged in feb9a58814720a4382d3f02467dcecb276f58040. |