Bug 13980

Summary: Investigate replacements for PhantomJS for buildperf output
Product: [Infrastructure] AutoBuilder Reporter: Trevor Gamblin <tvgamblin>
Component: autobuilderAssignee: Unassigned <unassigned>
Status: RESOLVED OBSOLETE QA Contact:
Severity: enhancement    
Priority: Medium+ CC: infras.ab.watcher, Infras.watcher, pidge, randy.macleod, richard.purdie, ross.burton, tgamblin, tim.orling
Version: unspecified   
Target Milestone: 5.99   
Hardware: x86   
OS: Multiple   
Whiteboard:
OS type for building Yocto: --- Type of Regression: ---
Verified: Documentation change: Don't know

Description Trevor Gamblin 2020-07-10 10:52:40 UTC 
While investigating https://bugzilla.yoctoproject.org/show_bug.cgi?id=13977 (which is no longer failing), we noted that the mechanism uses the headless browser PhantomJS for image capture purposes. PhantomJS is no longer being actively worked on (see https://github.com/ariya/phantomjs/issues/15344) and the latest stable version is from 2016. While it still works and there is some activity on the GitHub repository, it is worth considering some more active alternatives:

Playwright: https://github.com/microsoft/playwright
Puppeteer: https://github.com/puppeteer/puppeteer
Comment 1 Ross Burton 2020-07-16 08:01:12 UTC 
Might be easier to just replace that code with dynamically generated charts instead, chartjs or so on can draw a chart on the client in HTML. This will give us interactive charts too.
Comment 2 Richard Purdie 2020-07-18 03:14:51 UTC 
Ross: The issue isn't the website which already uses dynamically generated charts, its sharing images in the performance machine emails. If we do away with the charts in the emails, we can drop this.

I suspect the issue is that client code execution from html emails is problematic.

The right answer could well be just to drop the functionality and concentrate on the web browsable stuff.
Comment 3 Ross Burton 2020-07-20 02:01:26 UTC 
I'd be entirely fine with the mail notifications being a high level summary of the report, and a link to a web page.
Comment 4 Richard Purdie 2020-07-20 08:48:51 UTC 
I'm leaning quite heavily to simplifying the email to just the text reports and a link...
Comment 5 Trevor Gamblin 2020-07-20 08:51:00 UTC 
Given how quickly JavaScript projects tend to change, that sounds like a good idea to me too. I still have this on my shortlist of things to do if we still want the screenshots, though.
Comment 6 Trevor Gamblin 2021-12-20 19:20:37 UTC 
Did we ever come to a conclusion on whether or not to simplify emails?
Comment 7 Randy MacLeod 2023-07-26 21:21:57 UTC 
Bulk move of 64 bugs to 4.3 M3 after a quick review.
If a bug is actually fixed, please add a commit link and resolve it.
-- Randy for YP bug team.
Comment 8 Trevor Gamblin 2023-09-14 15:46:50 UTC 
Moved to 5.0 M1.
Comment 9 Randy MacLeod 2023-12-21 23:28:29 UTC 
Bulk move of 52 5.0-M1 bugs to M2.
Comment 10 Randy MacLeod 2024-01-25 14:28:49 UTC 
Bulk move of bugs owned by "unassigned" from 5.0-M2 to 5.0-M3.