Bug 14040

Found while attempting this:
devtool add -b abi-dumper-native https://github.com/lvc/abi-dumper

The '-b' flag causes ';workdir=${BP}' to be tacked onto the SRC_URI. 

Since we didn't specify a PV, it takes the default:
PV = "1.0+git${SRCPV}"

But SRCPV is defined in terms of the SRC_URI, which leads to infinite recursion (traceback below). Here are the pertinent variables which cause the recursion:

SRC_URI = "git://github.com/lvc/abi-dumper;protocol=https;subdir=${BP}"
BP = "${BPN}-${PV}"
PV = "1.0+git${SRCPV}"
SRCPV = "${@bb.fetch2.get_srcrev(d)}"

def get_srcrev(d, method_name='sortable_revision'):
    # ... trimmed
    scms = []
    fetcher = Fetch(d.getVar('SRC_URI').split(), d)
    # ... trimmed


Suggested fix: when setting PV in terms of 'SRCPV', ensure that 'subdir=${BPN}' is used instead of 'subdir=${BP}'. Thoughts?



Traceback:

ERROR: Traceback (most recent call last):
  File "/home/laplante/yocto/sources/poky/bitbake/lib/bb/data_smart.py", line 411, in expandWithRefs
    s = __expand_python_regexp__.sub(varparse.python_sub, s)
  File "/home/laplante/yocto/sources/poky/bitbake/lib/bb/data_smart.py", line 110, in python_sub
    if "_remote_data" in self.d:
  File "/usr/lib/python3.6/_collections_abc.py", line 666, in __contains__
    self[key]
  File "/home/laplante/yocto/sources/poky/bitbake/lib/bb/data_smart.py", line 1021, in __getitem__
    value = self.getVar(item, False)
  File "/home/laplante/yocto/sources/poky/bitbake/lib/bb/data_smart.py", line 604, in getVar
    return self.getVarFlag(var, "_content", expand, noweakdefault, parsing)
RecursionError: maximum recursion depth exceeded

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/laplante/yocto/sources/poky/bitbake/lib/bb/command.py", line 74, in runCommand
    result = command_method(self, commandline)
  File "/home/laplante/yocto/sources/poky/bitbake/lib/bb/command.py", line 562, in parseRecipeFile
    envdata = parser.loadDataFull(fn, appendfiles)
  File "/home/laplante/yocto/sources/poky/bitbake/lib/bb/cache.py", line 324, in loadDataFull
    bb_data = self.load_bbfile(virtualfn, appends, virtonly=True)
  File "/home/laplante/yocto/sources/poky/bitbake/lib/bb/cache.py", line 337, in load_bbfile
    datastores = parse_recipe(bb_data, bbfile, appends, mc)
  File "/home/laplante/yocto/sources/poky/bitbake/lib/bb/cache.py", line 300, in parse_recipe
    bb_data = bb.parse.handle(bbfile, bb_data)
  File "/home/laplante/yocto/sources/poky/bitbake/lib/bb/parse/__init__.py", line 107, in handle
    return h['handle'](fn, data, include)
  File "/home/laplante/yocto/sources/poky/bitbake/lib/bb/parse/parse_py/BBHandler.py", line 141, in handle
    return ast.multi_finalize(fn, d)
  File "/home/laplante/yocto/sources/poky/bitbake/lib/bb/parse/ast.py", line 386, in multi_finalize
    finalize(fn, d)
  File "/home/laplante/yocto/sources/poky/bitbake/lib/bb/parse/ast.py", line 345, in finalize
    runAnonFuncs(d)
  File "/home/laplante/yocto/sources/poky/bitbake/lib/bb/parse/ast.py", line 329, in runAnonFuncs
    bb.utils.better_exec("\n".join(code), {"d": d})
  File "/home/laplante/yocto/sources/poky/bitbake/lib/bb/utils.py", line 396, in better_exec
    exec(code, get_context(), context)
  File "<code>", line 3, in <module>
  File "/home/laplante/yocto/sources/poky/meta/classes/base.bbclass", line 678, in __anon_706__home_laplante_yocto_sources_poky_meta_classes_base_bbclass
    fpaths = (d.getVar('FILESPATH') or '').split(':')
  File "/home/laplante/yocto/sources/poky/bitbake/lib/bb/data_smart.py", line 604, in getVar
    return self.getVarFlag(var, "_content", expand, noweakdefault, parsing)
  File "/home/laplante/yocto/sources/poky/bitbake/lib/bb/data_smart.py", line 802, in getVarFlag
    parser = self.expandWithRefs(value, cachename)