Bug 14070

Created attachment 4733 [details]
patch file to apply

Hi All,

I was trying "devtool modify" on one of my recipes (edk2-firmware.bb/bbappend for aarch64 platform). This recipe (both bb and bbappend) is not including any patches in SRC_URI. Even though its not using any patches, but devtool modify is failed at do_patch. How it can be failed at do_patch, since my recipes was not using any patches. As a hack, we can add do_patch[noexec]= "1" in recipes and bye pass the error. 

steps to replicate 

1. repo init -u ssh://git@git.linaro.org/landing-teams/working/arm/arm-reference-platforms-manifest.git -b master -m corstone700.xml
2. repo sync -j8
3. cd layers/meta-arm
4. git apply edk2-firmware-crostone.diff , I have attached patch file
5. cd -
   export MACHINE=corstone700-fvp
   export DISTRO=poky-tiny
   . ./setup-environment
6. devtool modify edk2-firmware

Error will be looks like below 

ERROR: Error executing a python function in exec_python_func() autogenerated:

The stack trace of python calls that resulted in this exception/failure was:
File: 'exec_python_func() autogenerated', lineno: 2, function: <module>
     0001:
 *** 0002:patch_task_postfunc(d)
     0003:
File: '/data_sdb/prabin/Abdel/build-poky-tiny/conf/../../layers/openembedded-core/meta/classes/patch.bbclass', lineno: 82, function: patch_task_postfunc
     0078:        stdout, _ = bb.process.run('git status --porcelain .', cwd=srcsubdir)
     0079:        if stdout:
     0080:            useroptions = []
     0081:            oe.patch.GitApplyTree.gitCommandUserOptions(useroptions, d=d)
 *** 0082:            bb.process.run('git add .; git %s commit -a -m "Committing changes from %s\n\n%s"' % (' '.join(useroptions), func, oe.patch.GitApplyTree.ignore_commit_prefix + ' - from %s' % func), cwd=srcsubdir)
     0083:}
     0084:
     0085:def src_patches(d, all=False, expand=True):
     0086:    import oe.patch
File: '/data_sdb/prabin/Abdel/bitbake/lib/bb/process.py', lineno: 182, function: run
     0178:        if not stderr is None:
     0179:            stderr = stderr.decode("utf-8")
     0180:
     0181:    if pipe.returncode != 0:
 *** 0182:        raise ExecutionError(cmd, pipe.returncode, stdout, stderr)
     0183:    return stdout, stderr
Exception: bb.process.ExecutionError: Execution of 'git add .; git -c user.name="OpenEmbedded" -c user.email="oe.patch@oe" commit -a -m "Committing changes from do_patch

%% ignore - from do_patch"' failed with exit code 1:
On branch devtool
Changes not staged for commit:
        modified:   edk2 (untracked content)

no changes added to commit


ERROR: Logfile of failure stored in: /data_sdb/prabin/Abdel/build-poky-tiny/tmp-poky_tiny/work/corstone700_fvp-poky-linux-musleabi/edk2-firmware/gitAUTOINC+11247ae126_1a785d6f0c-r0/devtooltmp-_d4cpxiq/temp/log.do_patch.27583
NOTE: Tasks Summary: Attempted 93 tasks of which 90 didn't need to be rerun and 1 failed.