| Summary: | npmsw does not support github URLs in the npm-shrinkwrap.json file | ||
|---|---|---|---|
| Product: | [Build System, Metadata & Runtime] BitBake | Reporter: | Paulo Castro <pefcastro> |
| Component: | bitbake | Assignee: | Mark <mark.asselstine> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | Medium+ | CC: | mark.asselstine, poky.bs.watcher, poky.watcher, randy.macleod |
| Version: | unspecified | ||
| Target Milestone: | 4.3 M4 | ||
| Hardware: | x86 | ||
| OS: | Multiple | ||
| Whiteboard: | |||
| OS type for building Yocto: | --- | Type of Regression: | --- |
| Verified: | Documentation change: | No (bug/feature does not impact docs) | |
|
Description
Paulo Castro
2021-02-17 13:50:16 UTC
It was also reported that npmsw does not support "the from: line to specify branches with commits not merged to master (branch must be specified in the version: line before the commit hash)".
I think it regards the "from" property of shrinkwrap blocks such as:
"multicast-dns": {
"version": "git+https://github.com/resin-io-modules/multicast-dns.git#a15c63464eb43e8925b187ed5cb9de6892e8aacc",
"from": "git+https://github.com/resin-io-modules/multicast-dns.git#listen-on-all-interfaces",
...
}
A valid bug but we don't have anyone to work on it. Paulo, would you like to work on this bug? Bumping to M2. This has partially been addressed by --- commit 1d8af6aed0a929f493d2c3e31b8d3ee3a70beb43 Author: Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com> Date: Thu Oct 28 14:41:43 2021 +0200 fetch2: npmsw: Add support for github prefix in npm shrinkwrap version --- I have added the other shortforms for bitbucket, gist, and gitlab along with some tests. I will send the review out next week. This was partially fixed by commit 1d8af6aed0a9 (Thu Oct 28 14:41:43 2021 +0200) [fetch2: npmsw: Add support for github prefix in npm shrinkwrap version] which added support for the github prefix. To complete the fix, commit 0ac6f6cb5d807919ed13a8b7bb3fb551b79c5a71 (Fri Feb 24 15:43:44 2023 -0500) [fetch/npmsw: add more short forms for git operations] was merged which adds support for the gist, gitlab and bitbucket prefixes as well as the gitlab short form which forgoes any prefix at all. |