Bug 14639

Summary: 0010-MIPS64-Default-to-N64-ABI.patch could be removed
Product: [Build System, Metadata & Runtime] OE-Core Reporter: Andrew Pinski <pinskia>
Component: devtools / tool chainAssignee: Richard Purdie <richard.purdie>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: Medium+ CC: meta.mr.watcher, meta.watcher, randy.macleod, richard.purdie
Version: unspecified   
Target Milestone: 4.0 M1   
Hardware: x86   
OS: Multiple   
Whiteboard:
OS type for building Yocto: --- Type of Regression: ---
Verified: Documentation change: No (bug/feature does not impact docs)

Description Andrew Pinski 2021-11-25 06:15:52 UTC 
Instead of carrying around the 0010-MIPS64-Default-to-N64-ABI.patch patch, you could use do the following inside gcc-target.inc:
EXTRA_OECONF:append:mips64:class-target = " --with-abi=64"

This is one less patch to carry forward really.
Comment 1 Andrew Pinski 2021-11-25 06:19:21 UTC 
Oh, I looked and gcc-configure-common.inc already does this:
EXTRA_OECONF:append:mips64 = " --with-abi=64 --with-arch-64=mips64 --with-tune-64=mips64"
EXTRA_OECONF:append:mips64el = " --with-abi=64 --with-arch-64=mips64 --with-tune-64=mips64"
EXTRA_OECONF:append:mips64n32 = " --with-abi=64 --with-arch-64=mips64 --with-tune-64=mips64"
EXTRA_OECONF:append:mips64eln32 = " --with-abi=64 --with-arch-64=mips64 --with-tune-64=mips64"
EXTRA_OECONF:append:mipsisa32r6el = " --with-abi=32 --with-arch=mips32r6"
EXTRA_OECONF:append:mipsisa32r6 = " --with-abi=32 --with-arch=mips32r6"
EXTRA_OECONF:append:mipsisa64r6el = " --with-abi=64 --with-arch-64=mips64r6"
EXTRA_OECONF:append:mipsisa64r6 = " --with-abi=64 --with-arch-64=mips64r6"

So this patch really could be removed without doing anything extra.
Comment 2 Richard Purdie 2021-11-25 15:06:15 UTC 
Thanks for the tip. we'll look into dropping that!