| Summary: | images_types: missing vname var init in multiubi_mkfs() | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Build System, Metadata & Runtime] OE-Core | Reporter: | Romuald Jeanne <romuald.jeanne> | ||||
| Component: | oe-core other | Assignee: | Alexandre Belloni <alexandre.belloni> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | Medium+ | CC: | alexandre.belloni, randy.macleod, romuald.jeanne | ||||
| Version: | 4.1.2 | ||||||
| Target Milestone: | 4.2 M4 | ||||||
| Hardware: | x86 | ||||||
| OS: | Multiple | ||||||
| Whiteboard: | |||||||
| OS type for building Yocto: | --- | Type of Regression: | Regression (Used to work) | ||||
| Verified: | Documentation change: | No (bug/feature does not impact docs) | |||||
| Attachments: |
|
||||||
I'm sorry for the delay, I've sent this to the autobuilders but the selftests are failing: https://autobuilder.yoctoproject.org/typhoon/#builders/80/builds/4814/steps/14/logs/stdio https://autobuilder.yoctoproject.org/typhoon/#/builders/87/builds/4897/steps/14/logs/stdio https://autobuilder.yoctoproject.org/typhoon/#/builders/86/builds/4862/steps/14/logs/stdio 2023-02-28 21:55:23,095 - oe-selftest - INFO - ====================================================================== 2023-02-28 21:55:23,095 - oe-selftest - INFO - FAIL: imagefeatures.ImageFeatures.test_image_fstypes (subunit.RemotedTestCase) 2023-02-28 21:55:23,096 - oe-selftest - INFO - ---------------------------------------------------------------------- 2023-02-28 21:55:23,096 - oe-selftest - INFO - testtools.testresult.real._StringException: Traceback (most recent call last): File "/home/pokybuild/yocto-worker/oe-selftest-fedora/build/meta/lib/oeqa/selftest/cases/imagefeatures.py", line 224, in test_image_fstypes self.assertTrue(os.path.exists(image_path), File "/usr/lib64/python3.11/unittest/case.py", line 715, in assertTrue raise self.failureException(msg) AssertionError: False is not true : ubi image /home/pokybuild/yocto-worker/oe-selftest-fedora/build/build-st-733784/tmp/deploy/images/qemux86-64/core-image-minimal-qemux86-64.ubi doesn't exist I confirm there was no ubi image generated. Can you fix the patch? To ensure a timely reply, the proper way to contribute is documented here: https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded Ok, so I've tried to set-up everything to send the patch as expected. I'm really used with git send-email, but it returns OK. Here's the log: $ git send-email --to=openembedded-core@lists.openembedded.org --confirm=always -M -1 /tmp/ZcHh2UuARB/0001-image_types-fix-vname-var-init-in-multiubi_mkfs-func.patch (mbox) Adding cc: Romuald JEANNE <romuald.jeanne@st.com> from line 'From: Romuald JEANNE <romuald.jeanne@st.com>' (body) Adding cc: Romuald JEANNE <romuald.jeanne@st.com> from line 'Signed-off-by: Romuald JEANNE <romuald.jeanne@st.com>' From: romuald.jeanne@st.com To: openembedded-core@lists.openembedded.org Cc: Romuald JEANNE <romuald.jeanne@st.com> Subject: [PATCH] image_types: fix vname var init in multiubi_mkfs() function Date: Fri, 3 Mar 2023 09:43:28 +0100 Message-Id: <20230303084328.14758-1-romuald.jeanne@st.com> X-Mailer: git-send-email 2.17.1 Send this email? ([y]es|[n]o|[q]uit|[a]ll): y OK. Log says: Sendmail: /usr/bin/msmtp -i openembedded-core@lists.openembedded.org romuald.jeanne@st.com From: romuald.jeanne@st.com To: openembedded-core@lists.openembedded.org Cc: Romuald JEANNE <romuald.jeanne@st.com> Subject: [PATCH] image_types: fix vname var init in multiubi_mkfs() function Date: Fri, 3 Mar 2023 09:43:28 +0100 Message-Id: <20230303084328.14758-1-romuald.jeanne@st.com> X-Mailer: git-send-email 2.17.1 Result: OK Patch on the list, under test. 8b5e1cce35e1 ("image_types: fix vname var init in multiubi_mkfs() function")
|
Created attachment 4925 [details] patch proposal Since introduction in openembedded-core master branch of commit images_types: isolate the write of UBI configuration SHA1 601294b35c83faa134e26844c65db59b42d5052f There is a missing init in multiubi_mkfs() function for 'vname' var. Proposal to keep the vname var init as previously done in multiubi_mkfs() function and it as parameter for wrtie_ubi_config() function. Patch attached for 'image-types.bbclass' file.