Bug 15065

Summary: image_types: enable multiubi build
Product: [Build System, Metadata & Runtime] OE-Core Reporter: Romuald Jeanne <romuald.jeanne>
Component: oe-core otherAssignee: Romuald Jeanne <romuald.jeanne>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: Medium CC: randy.macleod, richard.purdie
Version: 4.1.4   
Target Milestone: 4.2   
Hardware: x86   
OS: Multiple   
Whiteboard:
OS type for building Yocto: --- Type of Regression: ---
Verified: Documentation change: No (bug/feature does not impact docs)

Description Romuald Jeanne 2023-03-10 10:32:54 UTC
For multiubi build we use to set on machine side the MKUBIFS_ARGS_<label> and UBINIZE_ARGS_<label> vars.
But these vars are not available in 'do_image_multiubi' task environment, so the 'eval' commands run to set local 'mkubifs_args' and 'ubinize_args' vars, always init empty vars.
Then 'multiubi_mkfs()' calls abort with bbfatal ("MKUBIFS_ARGS and UBINIZE_ARGS have to be set...").

I suggest to expand all MKUBIFS_ARGS_<label> and UBINIZE_ARGS_<label> vars in
'do_image_multiubi' task to make them usable to init the local 'mkubifs_args' and 'ubinize_args' vars.
Comment 1 Randy MacLeod 2023-03-16 14:35:03 UTC
Merged but we could use some tests. Are you interested Romuald?
Comment 3 Randy MacLeod 2023-03-16 14:36:19 UTC
See previous question
Comment 4 Romuald Jeanne 2023-03-16 15:25:07 UTC
What do you mean by "use some tests"?
Anyway I'm ok for some tests. Let me know how I can help.
Comment 5 Richard Purdie 2023-03-16 16:38:19 UTC
If you look at meta/lib/oeqa/selftest/cases/imagefeatures.py for example, test_image_fstypes does briefly test multiubi but only that it basically works, nothing about configuration options. You'd run this with "oe-selftest -r imagefeatures" 

We were hoping we could add some more specific tests for the multiubi image type to ensure the fixes you've added don't regress.
Comment 6 Romuald Jeanne 2023-03-17 14:44:19 UTC
Ok, thanks for the hint.
I'll check this part and try to write something to propose an update for multiubi test by the end of next week.
Comment 7 Romuald Jeanne 2023-03-20 13:50:37 UTC
I've just sent a patch to the mailing list to implement a test on test_image_fstypes.
Please refer to e-mail with subject:
[PATCH] oeqa/selftest/imagefeatures: set a test for mutliubi in test_image_fstypes