Bug 15243

Summary:	Patchtest deletes all local changes when running
Product:	[Yocto Project Subprojects] Patchwork/Patchtest	Reporter:	Ross Burton <ross.burton>
Component:	Patchtest	Assignee:	Trevor Gamblin <tgamblin>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	High	CC:	randy.macleod
Version:	unspecified
Target Milestone:	4.3 M4
Hardware:	x86
OS:	Multiple
Whiteboard:
OS type for building Yocto:	---	Type of Regression:	---
Verified:		Documentation change:	No (bug/feature does not impact docs)

Description Ross Burton 2023-10-19 11:47:32 UTC

If there are any local changes in the repository then patchtest will delete then when it test-applies the patches.

(the git reset --hard in repo.py)

If it insists on applying/reseting the current branch then it should _definitely_ refuse to run if there are local uncommitted changes.

Ideally, it could create a temporary worktree so it can run in a pristine branch.

Comment 1 Trevor Gamblin 2023-10-19 15:04:30 UTC

Patch in master to fix: https://git.yoctoproject.org/poky/commit/?id=4ba54e29ffa6e3dbfcb92752a759b805a2591a09

It logs an error to console and exits if there are local changes. The temporary worktree idea will be kept in mind for future patchtest refactors.