Bug 15390

Created attachment 5010 [details]
Patch with auh@yoctoproject.org as commit author

Greetings

I tested this on Poky master with the attached patch I prepared from an e-mail sent by the Auto Upgrade Helper:

mike@xps:~/work/yocto/poky$ patchtest --patch ~/tmp/patchtest-case/0003-alsa-ucm-conf-upgrade-1.2.10-1.2.11.patch 
Testing patch /home/mike/tmp/patchtest-case/0003-alsa-ucm-conf-upgrade-1.2.10-1.2.11.patch
Loading cache: 100% |                                                                                                                                                                              | ETA:  --:--:--
Loaded 0 entries from dependency cache.
Parsing recipes: 100% |#############################################################################################################################################################################| Time: 0:00:12
Parsing of 912 .bb files complete (0 cached, 912 parsed). 1849 targets, 47 skipped, 0 masked, 0 errors.
SKIP: pretest src uri left files: Patch cannot be merged (test_metadata.TestMetadata.pretest_src_uri_left_files)
SKIP: pretest pylint: No python related patches, skipping test (test_python_pylint.PyLint.pretest_pylint)
----------------------------------------------------------------------
Ran 2 tests in 13.504s

OK
PASS: test author valid (test_mbox.TestMbox.test_author_valid)
SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format)
PASS: test commit message presence (test_mbox.TestMbox.test_commit_message_presence)
PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head)
PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)
PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)
FAIL: test Signed-off-by presence: Mbox is missing Signed-off-by. Add it manually or with "git commit --amend -s" (test_mbox.TestMbox.test_signed_off_by_presence)
PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list)
Loading cache: 100% |###############################################################################################################################################################################| Time: 0:00:00
Loaded 1849 entries from dependency cache.
PASS: test CVE check ignore (test_metadata.TestMetadata.test_cve_check_ignore)
PASS: test lic files chksum modified not mentioned (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)
SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence)
SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence)
PASS: test max line length (test_metadata.TestMetadata.test_max_line_length)
SKIP: test src uri left files: Patch cannot be merged (test_metadata.TestMetadata.test_src_uri_left_files)
SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence)
SKIP: test CVE tag format: No new CVE patches introduced (test_patch.TestPatch.test_cve_tag_format)
SKIP: test Signed-off-by presence: No new CVE patches introduced (test_patch.TestPatch.test_signed_off_by_presence)
SKIP: test Upstream-Status presence: No new CVE patches introduced (test_patch.TestPatch.test_upstream_status_presence_format)
SKIP: test pylint: No python related patches, skipping test (test_python_pylint.PyLint.test_pylint)
----------------------------------------------------------------------
Ran 21 tests in 1.090s

OK

(Don't pay attention to the "FAIL" line, it's a different issue addressed by https://bugzilla.yoctoproject.org/show_bug.cgi?id=15389).

Patchtest should have warned me that the commit author was still "auh@yoctoproject.org <auh@yoctoproject.org>" and that I forgot to run "git commit --amend --reset-author".

I realized this, but after my first submission!