Bug 15642

Summary: uboot-sign.bbclass uboot_assemble_fitimage_helper() sends bad argument to concat_dtb()
Product: [Build System, Metadata & Runtime] OE-Core Reporter: Clayton Casciato <ccasciato>
Component: configurationAssignee: Clayton Casciato <ccasciato>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: Medium+ CC: randy.macleod, yoann.congal
Version: unspecified   
Target Milestone: 5.2 M1   
Hardware: x86   
OS: Multiple   
Whiteboard:
OS type for building Yocto: --- Type of Regression: ---
Verified: Documentation change: No (bug/feature does not impact docs)

Description Clayton Casciato 2024-11-06 22:47:29 UTC
Reviewing Scarthgap:

"do_uboot_assemble_fitimage()" has a branch that calls "uboot_assemble_fitimage_helper()" with two arguments: "" and "${UBOOT_BINARY}"

"uboot_assemble_fitimage_helper()" calls "concat_dtb()" with two unquoted arguments

In concat_dtb, this results in the "type" variable containing "${UBOOT_BINARY}" instead of "binary"

Potential resolution: quote the variables in "do_uboot_assemble_fitimage()"
Comment 1 Randy MacLeod 2024-11-07 15:38:46 UTC
Likely due to a quoting issues somewhere.
Have you tested this on master?
Can you send a patch to the oe-core list?
Comment 3 Clayton Casciato 2024-11-14 13:37:48 UTC
I submitted a patch last week and am awaiting feedback.

https://lists.openembedded.org/g/openembedded-core/message/206841