Bug 15662

Summary: do_rootfs_wicenv is not hash safe
Product: [Yocto Project Subprojects] Wic Reporter: kweihmann
Component: wicAssignee: Trevor Woerner <twoerner>
Status: ACCEPTED --- QA Contact:
Severity: normal    
Priority: Medium+ CC: hongxu.jia, meta.mr.watcher, meta.watcher, randy.macleod, richard.purdie, ross.burton, sam, twoerner, yoann.congal
Version: v0.3.0   
Target Milestone: v0.4.0   
Hardware: x86   
OS: Multiple   
Whiteboard:
OS type for building Yocto: --- Type of Regression: ---
Verified: Documentation change: Don't know

Description kweihmann 2024-11-26 14:45:49 UTC
https://git.yoctoproject.org/poky/tree/meta/classes-recipe/image_types_wic.bbclass?h=master#n12 lists BBLAYERS, that does contain a host specific paths to end up as a direct dependency of do_rootfs_wicenv (https://git.yoctoproject.org/poky/tree/meta/classes-recipe/image_types_wic.bbclass?h=master#n209).

at least TOPDIR needs to be taken out of the task signature calculation
Comment 1 Randy MacLeod 2024-11-28 15:46:27 UTC
Does WIC actually use bblayers or can we just remove it?
Comment 2 kweihmann 2024-11-28 16:04:12 UTC
Likely used for plugin discovery - so I think it's needed
Comment 3 Richard Purdie 2024-12-05 15:57:03 UTC
Rather than adding TOPDIR we should probably be recording which plugin this resolves to so that the hash only changes when the plugin being used changes. Is that something you could help us with a patch for?
Comment 4 kweihmann 2024-12-05 15:59:03 UTC
@Richard
I would, but recent policy changes at Microsoft make it impossible to contribute to the project.
So I'm afraid I can't provide patches
Comment 5 Ross Burton 2024-12-12 16:19:30 UTC
I'm guessing that by "policy changes at Microsoft" you mean that you can't send patches via outlook.com.  I'm surprised by that, mainly because all of my patches route through Exchange, so I'm curious what the problem is.

However, there is an alternative: the "b4" tool can send messages to the mailing list over HTTP.

The documentation for the send command is at https://b4.docs.kernel.org/en/latest/contributor/send.html (you can use the kernel endpoint, as the lists are hosted at the same place).  A worked example of contributing a kernel patch is at https://people.kernel.org/monsieuricon/sending-a-kernel-patch-with-b4-part-1.

Hopefully that is useful to you.
Comment 6 Randy MacLeod 2025-01-30 16:06:38 UTC
Bulk move to 5.2-M3.
Comment 7 Randy MacLeod 2025-01-30 16:17:04 UTC
Bulk move to 5.2-M3 and this time I'll actually specify M3!
Comment 8 Randy MacLeod 2025-05-01 14:09:06 UTC
Bulk move of most 5.2-M4 unassigned bugs to 5.3-M2.
Comment 9 Randy MacLeod 2025-08-07 18:38:32 UTC
Leaving at M2 for discussion since there are wic changes that I'm aware of but not following closely.

Trevor, Hongxu, Keith, Is this still a problem?
Comment 10 Randy MacLeod 2026-04-01 19:09:57 UTC
The wic work may land before 6.0 GA so bump to M4.
Comment 11 Sam Kent 2026-04-30 08:40:24 UTC
I've submitted a patch that I think solves this

https://lists.openembedded.org/g/openembedded-core/topic/patch_1_2_image_types_wic/119078158

Thanks,
Sam
Comment 12 Randy MacLeod 2026-05-28 13:17:57 UTC
Bulk move of unassigned 6.0-M* bugs to 6.1-M2.