| Summary: | cml1.bbclass: Invalid shell syntax in line 61: "\\$?" | ||
|---|---|---|---|
| Product: | [Build System, Metadata & Runtime] OE-Core | Reporter: | Sven Kalmbach <Sven.Kalmbach> |
| Component: | oe-core other | Assignee: | Sven Kalmbach <Sven.Kalmbach> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | Medium+ | CC: | christoph.vogtlaender, randy.macleod, yoann.congal |
| Version: | 5.0.6 | ||
| Target Milestone: | Future | ||
| Hardware: | x86 | ||
| OS: | x86_64 | ||
| Whiteboard: | |||
| OS type for building Yocto: | --- | Type of Regression: | --- |
| Verified: | Documentation change: | No (bug/feature does not impact docs) | |
Sven can you send a patch to the list? If so, see: https://docs.yoctoproject.org/contributor-guide/index.html (In reply to Randy MacLeod from comment #1) > Sven can you send a patch to the list? > > If so, see: https://docs.yoctoproject.org/contributor-guide/index.html I'll check out the guide, if I find the time :) Hoping the Sven can find the time. (In reply to Randy MacLeod from comment #3) > Hoping the Sven can find the time. I found the time (https://lists.openembedded.org/g/openembedded-core/topic/patch_fixes_yocto_15731/111143606). I hope the patch is formatted well enough, since I can not use git send-email. I've implemented the fix since last time and sent a (well-formated) patch to the mailing list (https://lists.openembedded.org/g/openembedded-core/message/211948) Thanks Sven, it's merged to master and walnascar: https://git.openembedded.org/openembedded-core/commit/?id=5c44a9154f0cd4252d4840d836e6936393b5d3a3 ❯ git branch -a --contains 5c44a9154f0cd4252d4840d836e6936393b5d3a3 * master remotes/origin/HEAD -> origin/master remotes/origin/master remotes/origin/master-next remotes/origin/walnascar |
Lines 61-62 of cml1.bbclass contains: > oe_terminal("sh -c 'make %s; if [ \\$? -ne 0 ]; then ... Escaping $? is wrong in this context, as it's already escaped by the quotes. This causes the error handling logic not to run if make fails. The double backslash can be removed.