Bug 1691

Summary: [HOB] make IMAGES_TYPE a per recipe setting
Product: [Build System, Metadata & Runtime] Hob Reporter: Matthew McClintock <msm-oss>
Component: hobAssignee: Cristiana Voicu <cristiana.voicu>
Status: RESOLVED WONTFIX QA Contact:
Severity: enhancement    
Priority: Medium CC: belen.barros.pena, dongxiao.xu, jessica.zhang, jiajun.xu, msm-oss, poky.bs.watcher, poky.watcher, richard.purdie, sgw, song.liu
Version: unspecified   
Target Milestone: 1.7   
Hardware: x86   
OS: Multiple   
Whiteboard:
OS type for building Yocto: --- Type of Regression: ---
Verified: Documentation change: No (bug/feature does not impact docs)
Bug Depends on: 1744    
Bug Blocks:    

Description Matthew McClintock 2011-10-21 11:05:01 UTC
IMAGES_TYPE default should be that of the given machine and image. If you save a recipe off - then when you open it the IMAGES_TYPE should be saved with that. It should not be a globally persistant setting.

-M
Comment 1 Dongxiao Xu 2011-12-29 21:48:04 UTC
Could you describe the "save a recipe off" in more detail? We are not understanding this point well.
Comment 2 Matthew McClintock 2012-01-04 14:39:52 UTC
(In reply to comment #1)
> Could you describe the "save a recipe off" in more detail? We are not
> understanding this point well.

If you change the types of IMAGES generated in hob this is saved globally. So if I select tar.gz tar.bz2 and tar.xz then for each image (core-image-sato, core-image-lsb-sdk, etc) I build within hob all these values are defined.

In reality this should be saved per custom image and not globally, so if I make recipes they should save the IMAGES_TYPES in the recipe:

hob-image-custom1: tar.gz
hob-image-custom2: tar.bz2
hob-image-custom3: tar.gz tar.bz2 tar.xz

In summary we need  to move setting IMAGE_FSTYPES from 'conf/hob-post.conf' to 'hob-image-customN.bb'
Comment 3 Belen Barros Pena 2012-05-25 14:58:16 UTC
Hi, Matthew: 

I am currently looking at the design of the Hob settings, and I am just wondering if this feature has any impact in the GUI. 

Are you suggesting that the image types should be set per base image (i.e each of the base images available for selection in Hob should have a set of image types linked to it)?

Thanks,

Belen
Comment 4 Matthew McClintock 2012-05-25 20:13:40 UTC
(In reply to comment #3)
> Hi, Matthew: 
> 
> I am currently looking at the design of the Hob settings, and I am just
> wondering if this feature has any impact in the GUI. 
> 
> Are you suggesting that the image types should be set per base image (i.e
> each of the base images available for selection in Hob should have a set of
> image types linked to it)?
> 
> Thanks,
> 
> Belen

This does not need to effect the GUI. It just effects the saved .bb files. This myimage.bb file should have the IMAGE_FSTYPES and not the hob-{pre,post}.conf files.

That way if I make my own custom image with my own custom packages it also saves my own custom image type I selected as well.

-M
Comment 5 Jessica 2013-03-07 19:15:40 UTC
Relate to overal refactor of configuration changes for hob
Comment 6 Richard Purdie 2014-05-03 17:35:36 UTC
At this point, work will take place on toaster, not hob so marking as won't fix.