| Summary: | [Hob2] Line length for base image descriptions changes between images | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Build System, Metadata & Runtime] Hob | Reporter: | Belen Barros Pena <belen.barros.pena> | ||||||
| Component: | hob | Assignee: | anliming <limingx.l.an> | ||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||
| Severity: | minor | ||||||||
| Priority: | Low | CC: | jessica.zhang, jiajun.xu, poky.bs.watcher, poky.watcher, sgw, shane.wang, song.liu | ||||||
| Version: | 1.4 | ||||||||
| Target Milestone: | 1.3 M1 | ||||||||
| Hardware: | x86 | ||||||||
| OS: | Multiple | ||||||||
| Whiteboard: | (P1)(Scheduled) | ||||||||
| OS type for building Yocto: | --- | Type of Regression: | --- | ||||||
| Verified: | Documentation change: | --- | |||||||
| Attachments: |
|
||||||||
Created attachment 482 [details]
short line length on base image description
Hi Belen, I add a patch to fixed it. http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=limx/hob-bug-fixes-continue Hi Liming, Has the patch been merged to master? I cannot see the fix. Thanks! Belen Hi Liming, I can see the fix now. It is almos there. Most lines are nicely set to around 65 characters. There are a few of them that could be improved a bit. They are: 1. core-image-core. Please change to: Line 1 (62 chars): An X11 image with simple applications such as terminal, editor Line 2 (17 chars): and file manager. 2. core-image-rt. Please change to: Line 1 (62 chars): A small image just capable of allowing a device to boot plus a Line 2 (61 chars): real-time test suite and tools appropriate for real-time use. 3. core-image-sato. Please change to: Line 1 (65 chars): Image with Sato, a mobile environment and visual style for mobile Line 2 (58 chars): devices. The image supports X11 with a Sato theme, Pimlico Line 3 (61 chars): applications, and contains terminal, editor and file manager. 4. Create your own image. Please change to: Line 1 (65 chars): Use the “View recipes” and “View packages” options to select what Line 2 (34 chars): you want to include in your image. Thanks! Belen Sorry, I forgot one: core-image-minimal-dev. Please change to: Line 1 (62 chars): A small image just capable of allowing a device to boot and is Line 2 (30 chars): suitable for development work. Belen Hi Belen, The patch I had submitted has some case I don't care as your metioned, Thanks! but there has another case need to be concern, and this case can effect how to set the work way about 'running image' or 'deploy image'.please to review. Maybe there has someone want to running the image only use the image which be build by hob and with their own kernel file. the current work way of clicked the 'running image' as this bug design is: if there has only one qemu image and one kernel file after building, it can be run by clicked the 'running image' button directly. can not support this case.please to refer it?(metioned by Dongxiao) Very Sorry,the last comment I write is wrong. Hi Belen, I had changed line width mostly as your design, but the 'core-image-sato' can not be adjusted to a equal width as your descripted, please to review.http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=limx/hob-bug-fixes-continue Hi Liming, This looks good to me. Setting the bug to resolved - fixed. I'll verify it when merged to master. Thanks! Belen verified in master branch. Looking good. Thanks! |
Created attachment 481 [details] Long line length in base image description We should select a line length and apply it consistently across descriptions. This is a minor issue which should aim to fix for 1.3