Bug 246

Summary: non root install patch is not necessary
Product: [Build System, Metadata & Runtime] Meta-yocto Reporter: Ke Yu <ke.yu>
Component: meta-yoctoAssignee: Mei Lei <lei.mei>
Status: VERIFIED FIXED QA Contact:
Severity: enhancement    
Priority: Medium CC: jessica.zhang, kevin.tian, poky.bs.watcher, poky.watcher, richard.purdie, sgw
Version: 0.9   
Target Milestone: 1.0 M1   
Hardware: x86   
OS: Multiple   
Whiteboard:
OS type for building Yocto: --- Type of Regression: ---
Verified: Program Management Documentation change: ---

Description Ke Yu 2010-08-30 19:15:15 UTC
non root install patch is the patch to not install package as root ownership. one example is meta/recipes-extended/at/files/nonrootinstall.patch:

"
--- at-3.1.10.2.orig/Makefile.in    2005-08-29 01:08:28.000000000 -0700
+++ at-3.1.10.2/Makefile.in 2010-07-21 17:06:01.000000000 -0700

-   $(INSTALL) -g root -o root -m 755 -d $(IROOT)$(etcdir)
-   $(INSTALL) -g root -o root -m 755 -d $(IROOT)$(bindir)
-   $(INSTALL) -g root -o root -m 755 -d $(IROOT)$(sbindir)
-   $(INSTALL) -g root -o root -m 755 -d $(IROOT)$(docdir)
-   $(INSTALL) -g root -o root -m 755 -d $(IROOT)$(atdocdir)
-   $(INSTALL) -g $(DAEMON_GROUPNAME) -o $(DAEMON_USERNAME) -m 755 -d $(IROOT)$(ATSPOOL_DIR) $(IROOT)$(ATJOB_DIR)
+   $(INSTALL) $(INSTALLOWN) -m 755 -d $(IROOT)$(etcdir)
+   $(INSTALL) $(INSTALLOWN) -m 755 -d $(IROOT)$(bindir)
+   $(INSTALL) $(INSTALLOWN) -m 755 -d $(IROOT)$(sbindir)
+   $(INSTALL) $(INSTALLOWN) -m 755 -d $(IROOT)$(docdir)
+   $(INSTALL) $(INSTALLOWN) -m 755 -d $(IROOT)$(atdocdir)
+   $(INSTALL) $(INSTALLOWN) -m 755 -d $(IROOT)$(ATJOB_DIR)
+   $(INSTALL) $(DAEMONOWN) -m 755 -d $(IROOT)$(ATSPOOL_DIR)
"

In the early time, the poky build system can not handle the root install, so non-root install patch is necessary. Later "pseudo" package allow build system to handle the root install, so such kind of non-root install patch is not necessary any more.

so we can search all such kind of non-root install patch, and remove them.
Comment 1 Ke Yu 2010-09-20 19:40:42 UTC
Assign to Lei
Comment 2 Mei Lei 2010-09-27 17:57:47 UTC
I searched all such kind of non-root install patches, I will remove them.
Comment 3 Mei Lei 2010-10-25 19:03:51 UTC
I removed nonrootinstall patch, and use a patch named nonstripbinaries.patch to modify the /at-3.1.10.2/Makefile.in, so it can also handles stripping of the binaries.

Fixed by 
http://git.pokylinux.org/cgit/cgit.cgi/poky/commit/?id=0e0d14ed1e88ebff876abb3d00b08627a3879e8d
Comment 4 Ke Yu 2010-12-13 01:03:05 UTC
verified