Bug 2527

Summary:	grub-efi-native fails due to help2man script
Product:	[Build System, Metadata & Runtime] Other YP Layers	Reporter:	Paul Eggleton <bluelightning>
Component:	layers	Assignee:	Radu Moisan <radu.moisan>
Status:	VERIFIED FIXED	QA Contact:
Severity:	major
Priority:	Medium	CC:	alexandru.c.georgescu, dvhart, hongnax.xu, japier_07, jiajun.xu, laurentiu.serban, meta.layer.watcher, meta.watcher, ningx.ma, yilongx.y.sun
Version:	1.3
Target Milestone:	1.3 M3
Hardware:	x86
OS:	Multiple
Whiteboard:	(patch review v2)
OS type for building Yocto:	---	Type of Regression:	---
Verified:		Documentation change:	---
Bug Depends on:
Bug Blocks:	1919

Description Paul Eggleton 2012-06-01 12:46:38 UTC

http://autobuilder.yoctoproject.org:8010/builders/cedartrail/builds/96

------------ snip -------------
| PATH=.:$PATH /srv/home/pokybuild/yocto-autobuilder/yocto-slave/cedartrail/build/scripts/help2man --section=1 -i ./docs/man/grub-mkrescue.h2m -o grub-mkrescue.1 grub-mkrescue
...
| make[2]: *** [grub-mkrescue.1] Error 1
------------ snip -------------

help2man is being invoked directly, and our fake help2man script returns an error (1) which is intended to force a fallback to proper manpages, but for grub-efi there is apparently no such fallback, and thus the build fails.

Incidentally it might be worth making our fake help2man script actually print something so we know exactly what's gone wrong.

Comment 1 Javeir Arantes 2012-06-21 16:10:15 UTC

Error with the grub-efi-native_1.99.bb of openembedded core, the description is in this link 

http://comments.gmane.org/gmane.linux.embedded.yocto.general/7102

Comment 2 Darren Hart 2012-07-02 17:30:29 UTC

If grub-efi

+DEPENDS = "help2man-native"

Then why does our script come into play at all? Shouldn't it find the help2man-native we built?

Comment 3 Paul Eggleton 2012-07-02 20:01:26 UTC

That DEPENDS entry should not be there. Our help2man script comes out of the box, no need to build anything.

Comment 4 Darren Hart 2012-07-18 14:54:51 UTC

There is a workaround in place in master:

70067f082af279b58247467ec29283b310a1575e

I don't know if this is the proper fix or not.

Comment 5 Paul Eggleton 2012-07-18 15:43:29 UTC

From the description it looks like an ideal solution to me. I'm guessing though that we should probably remove help2man-native from DEPENDS.

Comment 6 Radu Moisan 2012-07-20 11:23:15 UTC

cedartrail build ok now.
removed help2man dependency as suggested, patch pending review.

Comment 7 Darren Hart 2012-07-20 15:11:50 UTC

Please do not mark a bug as RESOLVED until the patch is pulled into master (or the approprirate stable branch). If someone finds a flaw with your patch, this could still sit in development for a while. When the patch is pulled in, then we change to RESOLVED/FIXED and copy a link to the commit (on git.yoctoproject.org) here in bugzilla.

Comment 8 Radu Moisan 2012-07-23 06:51:44 UTC

(In reply to comment #7)
> Please do not mark a bug as RESOLVED until the patch is pulled into master
> (or the approprirate stable branch). If someone finds a flaw with your
> patch, this could still sit in development for a while. When the patch is
> pulled in, then we change to RESOLVED/FIXED and copy a link to the commit
> (on git.yoctoproject.org) here in bugzilla.

I moved the bug to RESOLVED only after the patch was merged, but did not paste a link in here.
The patch in master is 24340ed5d1f153610a0452e48babcadd4fc50b63

Comment 9 Darren Hart 2012-07-23 15:56:55 UTC

(In reply to comment #8)
> (In reply to comment #7)
> > Please do not mark a bug as RESOLVED until the patch is pulled into master
> > (or the approprirate stable branch). If someone finds a flaw with your
> > patch, this could still sit in development for a while. When the patch is
> > pulled in, then we change to RESOLVED/FIXED and copy a link to the commit
> > (on git.yoctoproject.org) here in bugzilla.
> 
> I moved the bug to RESOLVED only after the patch was merged, but did not
> paste a link in here.
> The patch in master is 24340ed5d1f153610a0452e48babcadd4fc50b63

OK, your comment above read "patch pending review", which I took to mean it had not been merged yet. Great that it's in and this is done, Thanks!

Comment 10 Laurentiu Serban 2012-08-18 20:55:55 UTC

On autobuildert this is not reproduced anymore.
Setting this bug to verified for revision 8b8748c8f963900b83dc0fdd7757556f917fe4fd