Bug 262

Summary: guilt is missing when patching x86-64 wr kernel
Product: [Build System, Metadata & Runtime] Meta-yocto Reporter: Kevin Tian <kevin.tian>
Component: meta-yoctoAssignee: Bruce Ashfield <bruce.ashfield>
Status: VERIFIED FIXED QA Contact:
Severity: critical    
Priority: High CC: kevin.tian, poky.bs.watcher, poky.watcher, richard.purdie, sgw
Version: 0.9   
Target Milestone: 0.9 M4   
Hardware: x86   
OS: Multiple   
Whiteboard:
OS type for building Yocto: --- Type of Regression: ---
Verified: Program Management Documentation change: ---

Description Kevin Tian 2010-09-02 20:01:03 UTC
autobuilder all x86-64 targets failed with below error:

  [################################################# ] (-)(98 %)
/srv/home/pokybuild/poky-slave/nightly-release/build/build/tmp/sysroots/x86_64-linux/usr/bin/kgit-meta: line 642: guilt-push: command not found
| [ERROR] unable to complete push
| pending patches are:
| /srv/home/pokybuild/poky-slave/nightly-release/build/build/tmp/sysroots/x86_64-linux/usr/bin/kgit-meta: line 664: guilt: command not found
| ERROR. could not update git tree

It looks that guilt-native is not listed as the dependency for kern-tools, but I don't understand why this only happens on x86-64 target. It looks triggered by below commit:

commit 1ff9c93e49b82a4ec89afc537ba096134a596bda
Author: Bruce Ashfield <bruce.ashfield@windriver.com>
Date:   Wed Sep 1 00:47:02 2010 -0400

     updateme: detect and prepare patches

    The big part of this commit is to detect and prepare any
    "free floating" patches into a kernel feature that will be
    automatically applied to the kernel tree. These patches will
    be pushed onto the BSP branch via guilt, and then built as
    part of the normal build/deploy cycle.

    There are other grouped cleanups, such as tabs instead
    of spaces, and the removal of the unused decheckpoint
    function.

    Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>
Comment 1 Kevin Tian 2010-09-02 20:07:28 UTC
I double checked that guilt-native is not marked as dependency for kern-tools, and my workdir never has guilt built. It's possible that only x86-64 target has those "free floating" patches. I sent out a fix to poky ml:

http://git.pokylinux.org/?p=poky-contrib.git;a=commitdiff;h=f7e677f63790f60c55da3bab35e6119a8149c79e

But I don't have a x86-64 local build, so may wait for next autobuilder for verification
Comment 2 Bruce Ashfield 2010-09-02 22:17:58 UTC
This is the right temporary fix, in the sense that the dependency
is required.

The x86-64 patches will go away when they are merged to the
kernel tree as well .. fixing this in another way.
Comment 3 Kevin Tian 2010-09-09 18:51:05 UTC
this is fixed by:

commit 5c1638ced33daa823f1b74a286fcae23818a74c2
Author: Kevin Tian <kevin.tian@intel.com>
Date:   Fri Sep 3 10:47:04 2010 +0800

    kern-tools: add dependency on guilt-native

    Fix [BUGID #262]

    Signed-off-by: Kevin Tian <kevin.tian@intel.com>
Comment 4 Kevin Tian 2010-10-21 01:05:13 UTC
verified this has been fixed