Bug 2731

Summary:	webkit-gtk fails to build for mips
Product:	[Build System, Metadata & Runtime] OE-Core	Reporter:	Khem Raj <raj.khem>
Component:	core	Assignee:	valentin <valentin.popa>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	Medium	CC:	laurentiu.serban, meta.mr.watcher, meta.watcher, ross.burton
Version:	1.3
Target Milestone:	1.3 M3
Hardware:	x86
OS:	mips
Whiteboard:
OS type for building Yocto:	---	Type of Regression:	---
Verified:		Documentation change:	---

Description Khem Raj 2012-07-10 14:17:40 UTC

webkit-gtk does not build for mips

| In file included from ./Source/JavaScriptCore/wtf/PassRefPtr.h:25:0,
|                  from ./Source/JavaScriptCore/wtf/RefPtr.h:28,
|                  from ./Source/JavaScriptCore/wtf/HashFunctions.h:24,
|                  from ./Source/JavaScriptCore/wtf/HashTraits.h:24,
|                  from ./Source/JavaScriptCore/wtf/HashTable.h:28,
|                  from ./Source/JavaScriptCore/wtf/HashMap.h:24,
|                  from ./Source/JavaScriptCore/runtime/JSValue.h:31,
|                  from ./Source/JavaScriptCore/runtime/CallData.h:32,
|                  from Source/JavaScriptCore/jit/JITStubs.h:33,
|                  from Source/JavaScriptCore/jit/JITStubs.cpp:34:
| ./Source/JavaScriptCore/wtf/NullPtr.h:50:1: warning: identifier 'nullptr' is a keyword in C++11 [-Wc++0x-compat]
| Source/JavaScriptCore/jit/JITPropertyAccess.cpp: In static member function 'static bool JSC::JIT::isDirectPutById(JSC::StructureStubInfo*)':
| Source/JavaScriptCore/jit/JITPropertyAccess.cpp:1160:25: error: 'readCallTarget' is not a member of 'JSC::MacroAssembler'

Comment 1 Khem Raj 2012-07-12 19:37:48 UTC

Please backport the fix from the below bug to fix it

https://bugs.webkit.org/show_bug.cgi?id=73432

Also for ARM look into 

https://bugs.webkit.org/show_bug.cgi?id=73413

and for SH

https://bugs.webkit.org/show_bug.cgi?id=73434

alltogether they will fix arm,sh4 and mips

Comment 2 Ross Burton 2012-07-24 15:08:55 UTC

webkit-gtk was upgraded to 1.8.1, can you see if that version works on ARM/MIPS/SH?

Comment 3 Khem Raj 2012-07-24 15:31:11 UTC

(In reply to comment #2)
> webkit-gtk was upgraded to 1.8.1, can you see if that version works on
> ARM/MIPS/SH?

yes the patches I suggested were backports anyway. I can see that it works on mips now.

Comment 4 Laurentiu Serban 2012-08-18 15:48:11 UTC

verified with commit: efcb0a81d8ab5d8e250c677cd6919b19172683d1
The issue is not reproduced.