Bug 3011

-Created a basic BaseHobButton class that uses gtk settings for buttons taken from host theme 
-All buttons in the interface inherit a BaseHobButton
-Removed 'or' label between actions on image details page

Is this what was intended ?

[Patch sent to bitbake-devel mailing list]

Hi Ionana,

I am going to reopen this because there are a couple of small tweaks we need to make in the buttons. In some of them, the width and height seem to be a bit off. For example:

- During the recipe parsing, the 'stop' button is too high (see stop-button.png)
- In the 'Edit recipes' and 'Edit packages' screens, the 'Build image' button is too wide, the 'Cancel' and 'View log' buttons are too narrow (see edit-packages-buttons.png and edit-recipes-buttons.png)
- In the 'Image details' screen, the 'Edit configuration' button is too high, the 'Build new image' and 'Run image' buttons are too wide, and 'Save as template' looks too narrow in comparison

I am not sure how GTK works when it comes to formatting components, but it seems as if we need a minimum width and a maximum height for buttons, and also a minimum padding for the labels. The right button proportions are the ones in the Settings dialog (see Cancel and Save buttons in right-button-proportions.png).

Do you think we can do something about this? Thanks!

Created attachment 792 [details]
stop-button.png

Created attachment 793 [details]
edit-packages-buttons.png

Created attachment 794 [details]
edit-recipes-buttons.png

Created attachment 795 [details]
image-details-buttons.png

Created attachment 796 [details]
right-button-proportions.png

I will start working on this, and keep you updated.

I have been investigating how to set a default minimal width and height for the buttons in the whole application.
From what I have seen, the buttons in the Settings Dialog, that we use as a reference, are created directly by the gtk, being part of a gtk.Dialog that uses the settings from the current host theme.
On the other hand, the buttons on the "Image Configuration" page, for example, are attached to an existing table with hard coded relative position to left, right, top and bottom margins of the table. 
This is the reason why the width of the progress bar that appears while parsing the recipes, and along with it, the width and height of the 'Stop' button do not comply to the host theme default dimensions.
A quick fix without modifying greatly the layout of the application, would be to determine a hard coded default width and heigth value to apply to all components, but this will not take into account the host theme dimensions.
Modifying this page to take all the corresponding sizes and paddings from the host, means determining the default gtk settings for each component and replacing all hard coded positions with relative positions that use the default components sizes and paddings from the theme.
I have not found yet a way to determine this information from gtk.settings. I will investigate this further.

I have sent a patch on list with the following changes:

- removed all set_size_request calls for buttons in order to:
	- force autosizing of buttons with regard to the text length
	- use host theme default height for buttons
- modified buttons on image details page to have the same height (default host one) and the width of the button with the largest text
- modified Stop button on build details page to have the default height by directly attaching it to the containing table instead of hbox

Currently the interface looks like in the attachments.

Created attachment 839 [details]
Updated stop button

Created attachment 840 [details]
Updated edit packages

Created attachment 841 [details]
Updated edit recipes

Created attachment 842 [details]
Updated image details

Commit : 0e1a427a2558ca09bc71b4d549c468198af7e01c

Neat work :) Thanks!