Bug 3107

Summary: In the 'Edit recipes' screen, recipes are shown as brought in by themselves
Product: [Build System, Metadata & Runtime] Hob Reporter: Belen Barros Pena <belen.barros.pena>
Component: hobAssignee: Cristiana Voicu <cristiana.voicu>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: Medium+ CC: bluelightning, cristian.iorga, cristiana.voicu, poky.bs.watcher, poky.watcher, valentin.popa
Version: unspecified   
Target Milestone: 1.3 M5   
Hardware: x86   
OS: Multiple   
Whiteboard: patch review
OS type for building Yocto: --- Type of Regression: ---
Verified: Documentation change: ---
Attachments:
Description Flags
acl brought by itself none

Description Belen Barros Pena 2012-09-13 15:02:52 UTC
Created attachment 799 [details]
acl brought by itself

Steps to reproduce:

1. Launch Hob
2. Select atom-pc as your machine and core-image-minimal as your base image
3. Click the 'edit image' button
4. In the 'Edit recipes' screen, click on the 'acl' recipe to display the 'Brought in by' information

Outcome: acl is brought by udev and acl. This happens with all other recipes in the table. I've attached a screenshot.

I don't think recipes should be brought in by themselves.
Comment 1 Cristiana Voicu 2012-09-25 10:06:32 UTC
This is not a bug. It is natural to show like this, because each recipes have some dependencies.
Comment 2 Belen Barros Pena 2012-09-27 09:14:17 UTC
You mean recipes depend on themselves? I might be wrong, but I asked before opening the bug and I was told this should not happen, i.e. recipes should not show as being brought in by themselves. I'll ask again though

(In reply to comment #1)
> This is not a bug. It is natural to show like this, because each recipes
> have some dependencies.
Comment 3 Paul Eggleton 2012-09-27 09:43:50 UTC
I'm not sure I understand where the self-dependency comes from, but even if it is valid internally it does not make sense to show this to the user - the idea of this column is to help users understand why a particular thing was selected, i.e. whether it was something they selected themselves, or the system selected it to satisfy a dependency; and if the latter which dependency specifically. Showing things depending on themselves can only increase confusion.
Comment 4 Cristiana Voicu 2012-09-28 07:39:05 UTC
patch merged to master
Comment 5 Belen Barros Pena 2012-09-28 11:04:08 UTC
fixed!