Bug 3235

Summary: Users should not be able to create projects containing spaces in their name
Product: [Yocto Project Subprojects] Eclipse Plugin Reporter: Alexandru Georgescu <alexandru.c.georgescu>
Component: eclipse-pluginAssignee: Jessica <jessica.zhang>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: Medium+ CC: corneliux.stoicescu, ioanax.grigoropol, yp.ep.watcher, yp.watcher
Version: 1.3   
Target Milestone: 1.3   
Hardware: x86   
OS: Multiple   
Whiteboard:
OS type for building Yocto: --- Type of Regression: ---
Verified: Documentation change: ---

Description Alexandru Georgescu 2012-10-04 15:16:47 UTC
Users should not be able to create projects containing spaces in their name. Currently, the user can add projects with spaces in their name.

Errors appear also when creating that kind of project: 


get env key PATH value /home/yocto/_rc3/toolchain/sdk/sysroots/x86_64-pokysdk-linux/usr/bin:/home/yocto/_rc3/toolchain/sdk/sysroots/x86_64-pokysdk-linux/usr/bin/i586-poky-linux:/usr/lib64/ccache:/usr/local/bin:/bin:/usr/bin:/usr/local/sbin:/usr/sbin:/home/yocto/.local/bin:/home/yocto/bin
get env key PKG_CONFIG_SYSROOT_DIR value /home/yocto/_rc3/toolchain/sdk/sysroots/i586-poky-linux
get env key PKG_CONFIG_PATH value /home/yocto/_rc3/toolchain/sdk/sysroots/i586-poky-linux/usr/lib/pkgconfig
get env key CONFIG_SITE value /home/yocto/_rc3/toolchain/sdk/site-config-i586-poky-linux
get env key CC value i586-poky-linux-gcc  -m32   -march=i586 --sysroot=/home/yocto/_rc3/toolchain/sdk/sysroots/i586-poky-linux
get env key CXX value i586-poky-linux-g++  -m32   -march=i586 --sysroot=/home/yocto/_rc3/toolchain/sdk/sysroots/i586-poky-linux
get env key CPP value i586-poky-linux-gcc -E  -m32   -march=i586 --sysroot=/home/yocto/_rc3/toolchain/sdk/sysroots/i586-poky-linux
get env key AS value i586-poky-linux-as
get env key LD value i586-poky-linux-ld   --sysroot=/home/yocto/_rc3/toolchain/sdk/sysroots/i586-poky-linux
get env key GDB value i586-poky-linux-gdb
get env key STRIP value i586-poky-linux-strip
get env key RANLIB value i586-poky-linux-ranlib
get env key OBJCOPY value i586-poky-linux-objcopy
get env key OBJDUMP value i586-poky-linux-objdump
get env key AR value i586-poky-linux-ar
get env key NM value i586-poky-linux-nm
get env key TARGET_PREFIX value i586-poky-linux-
get env key CONFIGURE_FLAGS value --target=i586-poky-linux --host=i586-poky-linux --build=x86_64-linux --with-libtool-sysroot=/home/yocto/_rc3/toolchain/sdk/sysroots/i586-poky-linux
get env key CFLAGS value  -O2 -pipe -g -feliminate-unused-debug-types
get env key CXXFLAGS value  -O2 -pipe -g -feliminate-unused-debug-types -fpermissive
get env key LDFLAGS value -Wl,-O1 -Wl,--hash-style=gnu -Wl,--as-needed
get env key CPPFLAGS value
get env key OECORE_NATIVE_SYSROOT value /home/yocto/_rc3/toolchain/sdk/sysroots/x86_64-pokysdk-linux
get env key OECORE_TARGET_SYSROOT value /home/yocto/_rc3/toolchain/sdk/sysroots/i586-poky-linux
get env key OECORE_ACLOCAL_OPTS value -I /home/yocto/_rc3/toolchain/sdk/sysroots/x86_64-pokysdk-linux/usr/share/aclocal
get env key OECORE_DISTRO_VERSION value 1.3
get env key OECORE_SDK_VERSION value 1.3
org.eclipse.cdt.core.templateengine.process.ProcessFailureException: Failed to make autogen.sh executable for project: project name with spaces
        at org.yocto.sdk.ide.wizard.NewYoctoProjectPostProcess.process(Unknown Source)
        at org.eclipse.cdt.core.templateengine.process.Process.process(Process.java:164)
        at org.eclipse.cdt.core.templateengine.process.ConditionalProcessGroup.process(ConditionalProcessGroup.java:220)
        at org.eclipse.cdt.core.templateengine.process.TemplateProcessHandler.processAll(TemplateProcessHandler.java:65)
        at org.eclipse.cdt.ui.templateengine.Template$1.execute(Template.java:192)
        at org.eclipse.ui.actions.WorkspaceModifyOperation$1.run(WorkspaceModifyOperation.java:106)
        at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2344)
        at org.eclipse.ui.actions.WorkspaceModifyOperation.run(WorkspaceModifyOperation.java:118)
        at org.eclipse.cdt.ui.templateengine.Template.executeTemplateProcesses(Template.java:202)
        at org.eclipse.cdt.managedbuilder.ui.wizards.MBSWizardHandler.doTemplatesPostProcess(MBSWizardHandler.java:643)
        at org.eclipse.cdt.managedbuilder.ui.wizards.MBSWizardHandler.createProject(MBSWizardHandler.java:560)
        at org.eclipse.cdt.internal.autotools.ui.wizards.AutotoolsBuildWizardHandler.createProject(AutotoolsBuildWizardHandler.java:43)
        at org.eclipse.cdt.ui.wizards.CDTCommonProjectWizard$1$1$1.run(CDTCommonProjectWizard.java:259)
        at org.eclipse.ui.actions.WorkspaceModifyDelegatingOperation.execute(WorkspaceModifyDelegatingOperation.java:69)
        at org.eclipse.ui.actions.WorkspaceModifyOperation$1.run(WorkspaceModifyOperation.java:106)
        at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2344)
        at org.eclipse.ui.actions.WorkspaceModifyOperation.run(WorkspaceModifyOperation.java:118)
        at org.eclipse.jface.operation.ModalContext.runInCurrentThread(ModalContext.java:464)
        at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:372)
        at org.eclipse.jface.wizard.WizardDialog.run(WizardDialog.java:1028)
        at org.eclipse.cdt.ui.wizards.CDTCommonProjectWizard$1$1.run(CDTCommonProjectWizard.java:268)
        at org.eclipse.ui.internal.UILockListener.doPendingWork(UILockListener.java:164)
        at org.eclipse.ui.internal.UISynchronizer$3.run(UISynchronizer.java:158)
        at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
        at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:135)
        at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:3529)
        at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3182)
        at org.eclipse.jface.operation.ModalContext$ModalContextThread.block(ModalContext.java:173)
        at org.eclipse.jface.operation.ModalContext.run(ModalContext.java:388)
        at org.eclipse.jface.wizard.WizardDialog.run(WizardDialog.java:1028)
        at org.eclipse.cdt.ui.wizards.CDTCommonProjectWizard.invokeRunnable(CDTCommonProjectWizard.java:177)
        at org.eclipse.cdt.ui.wizards.CDTCommonProjectWizard.getProject(CDTCommonProjectWizard.java:155)
        at org.eclipse.cdt.ui.wizards.CDTCommonProjectWizard.performFinish(CDTCommonProjectWizard.java:193)
        at org.eclipse.jface.wizard.WizardDialog.finishPressed(WizardDialog.java:827)
        at org.eclipse.jface.wizard.WizardDialog.buttonPressed(WizardDialog.java:432)
        at org.eclipse.jface.dialogs.Dialog$2.widgetSelected(Dialog.java:624)
        at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:248)
        at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
        at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1276)
        at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3554)
        at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3179)
        at org.eclipse.jface.window.Window.runEventLoop(Window.java:825)
        at org.eclipse.jface.window.Window.open(Window.java:801)
        at org.eclipse.ui.internal.actions.NewWizardShortcutAction.run(NewWizardShortcutAction.java:135)
        at org.eclipse.jface.action.Action.runWithEvent(Action.java:498)
        at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:584)
        at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:501)
        at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:411)
        at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
        at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1276)
        at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3554)
        at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3179)
        at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1022)
        at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
        at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:916)
        at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:86)
        at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:585)
        at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
        at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:540)
        at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
        at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:124)
        at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
        at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
        at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
        at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:353)
        at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:180)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:601)
        at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:629)
        at org.eclipse.equinox.launcher.Main.basicRun(Main.java:584)
        at org.eclipse.equinox.launcher.Main.run(Main.java:1438)
        at org.eclipse.equinox.launcher.Main.main(Main.java:1414)
Comment 1 Jessica 2012-10-05 22:23:41 UTC
commit cb8a0eff776d2cbd1b5f596a94dce825860574ab
Comment 2 Stoicescu Cornel 2012-10-10 11:31:22 UTC
What branch is that commit on? I checked denzil, danny and master but could not find it. Thank you.
Comment 3 Jessica 2012-10-10 15:56:23 UTC
In both master and danny but of eclipse-poky, here's the url http://git.yoctoproject.org/cgit/cgit.cgi/eclipse-poky/commit/?h=danny
Comment 4 Alexandru Georgescu 2013-03-11 15:46:16 UTC
verified, the user is not allowed to create a project with spaces in its name