Bug 3345

I have started to implement this feature, but I'm thinking if we really want this. All the buttons/labels/... in hob are for an image(in general). Adt-installer is not an image, so for this special case we will need something different. I have implemented it as a target like other, but it is weird to see a message like "Your image is ready" for adt_installer.

So, I think we need a special design for all the tools in yocto. What do you think?

I spoke with Jessica and we have agreed to hold on implementing this till we know how adt-installer will ook like for 1.4.

Thanks,
Cristiana

Hi Cristiana,

Just saw in your WSR that you have an implementation as an image. Do you have a branch I could look at? I might be able to help on how to adapt the actions and messages in Hob to the adt_installer case.

Thanks!

Belen

Hello Belen,

Sorry for the delay. Below you can find a branch with adt-installer target implemented in a hardcoded way. 

http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=cvoicu/adt-installer

Thanks,
Cristiana

Hi Cristiana and Jessica,

I've given the branch a go. The adt-installer build didn't complete (at some point during the build I got a blank screen and that was it), but I have some questions for the beginning of the building process. I am terribly ignorant when it comes to adt things, so please bear with me if my questions sound a bit daft or downright stupid :)

Q1: is the adt-installer build with Hob another way of using method 3 for installing the ADT (Use the Toolchain from within a Yocto Project Build Tree as explained on https://wiki.yoctoproject.org/wiki/How_to_setup_environment_for_ADT_with_1.1_on_Fedora_16)

Q2: what does it mean selecting a machine when building the adt-installer? Does it set the YOCTOADT_TARGETS variable? If so, it looks like this variable can take more than one architecture as its value: do we need to support that in Hob?

Q3: As Cristiana already mentioned, the 'Edit image' and 'Build image' labels don't make much sense for the adt-installer case. Would change them to 'Edit' and 'Build' make sense?

Q4: Should we have an 'Edit' capability for the adt-installer (i.e. should we allow users to modify the adt-installer included recipes)?

Q5: If the answer to Q4 is yes, does it makes sense to show all the Yocto Project recipes and Package Groups in the recipes screen? Does the label 'Build packages' make sense for the adt-installer case?

This is as far as I could get through the building flow (building packages brings up a blank screen as I mentioned above). I hope you can help me get some answers.

Thanks!!

Belen

Hello Belen,

Can you please try again to rebuild it? I hope I fixed it :)

Thanks,
Cristiana

Hi Gals,

Sorry, I've been meaning to reply to this bug, but always got distracted on sth. 

I don't think we should show adt-install as a target since it's not an image.  I'd suggest we move it to where we build our toolchains.  Also, there're some changes in 1.3 that allows user to build a customized toolchain to match their images that we need to make hob adapt as well.  So I'd suggest us to step back and rethink what's the best way for user to build toolchain (including adt-installer) using hob, bundle with adavanced setup or what else.

Thanks
Jessica

We need a design for this enhancement.

Created attachment 1044 [details]
3345 - Standalone ADT installer.pdf

Some alternative presentations of the ADT installer option in Hob. None of them are ideal in my opinion, so it is a question of choosing the least harmful of them all. To me, that's option 1 (add a "Build ADT installer" option to the list of machines). 

If you have any other suggestions, let me know.

Belen

Belen,

I'd like the 2nd options since get it stuck under machines it's ugly and meaningless if not even worse that confusing.  I'd change the box to "Tools" and in the window add "Build ADT Installer" kind of like what you have for option 3 but move to its own box of Tools.  In my mind, this way it's clean also if we have other tools that can be built, can to moved to this category as well.  Thougths?

(In reply to comment #10)
> Belen,
> 
> I'd like the 2nd options since get it stuck under machines it's ugly and
> meaningless if not even worse that confusing.  I'd change the box to "Tools"
> and in the window add "Build ADT Installer" kind of like what you have for
> option 3 but move to its own box of Tools.  In my mind, this way it's clean
> also if we have other tools that can be built, can to moved to this category
> as well.  Thougths?

Hi Jessica,

Thanks for looking at the options. Just to confirm I understand your suggestion: 

1. In the Advanced Configuration dialog, we create a new tab labelled 'Tools'
2. Inside that new Tools tab, we put the build toolchain, build ADT tarball and build ADT installer options

Is this correct?

Created attachment 1061 [details]
3345 - Standalone ADT installer (v2).pdf

The attached document shows the outcome of our phone discussion this evening. 

I have to insist I am not particularly happy: after managing to keep the screen so clean, all of a sudden we have 2 more controls out there. The adt installer button is particularly ugly :(

Let me know what you think.

Belen

Created attachment 1072 [details]
3345 - Standalone ADT installer (v3).pdf

New design based on Jessica's proposal outlined at

https://bugzilla.yoctoproject.org/show_bug.cgi?id=3808#c5

Jessica, Scott: could you please review the content of the information bubbles and tooltips and correct as needed? You'll find it in page 2 of the document.

Thanks!

I looked at page 2 of the attachment and the tooltips look fine.  No changes from me.

Scott

Thanks, Scott. If Jessica doesn't have any comments, design should be ready.

Belen

(In reply to comment #14)
> I looked at page 2 of the attachment and the tooltips look fine.  No changes
> from me.
> 
> Scott

Hi Crisiana,

I don't think the dependency exist any more since we won't change adt installation using sstate for 1.4.  But in general, Belen and I have finalized the over ADT (including adt-installer) design for hob that should be put in place.

Thanks,
Jessica

Hi, 

I am looking ahead a bit and thinking that we would want to add a section into the current Application Developer's Guide (old ADT manual) where we talk about the ADT installer that would address how to create the ADT Installer using Hob.  

As far as mainstream Hob documentation, though, there really is not any.  We just have what is on the YP site under Hob.  That could be checked into to see if this new capability could be mentioned.  I am sure that it should at least be "bulleted" in a list of what the thing can do.

Since this is for 1.6 I am primarily putting these thoughts down here to capture them in the context of the bug since the "Docs required" flag is turned on. 

Scott

At this point, work will take place on toaster, not hob, so marking as won't fix.