| Summary: | Hob doesn't tell me when my build fails because I ran out of disk space | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Build System, Metadata & Runtime] Hob | Reporter: | Belen Barros Pena <belen.barros.pena> | ||||||||||||||
| Component: | hob | Assignee: | Cristiana Voicu <cristiana.voicu> | ||||||||||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||||||||||
| Severity: | normal | ||||||||||||||||
| Priority: | Medium | CC: | andreea.b.proca, bluelightning, cristian.iorga, poky.bs.watcher, poky.watcher, sgw, srifenbark, valentin.popa | ||||||||||||||
| Version: | 1.3 | ||||||||||||||||
| Target Milestone: | 1.4 | ||||||||||||||||
| Hardware: | x86 | ||||||||||||||||
| OS: | Multiple | ||||||||||||||||
| Whiteboard: | merged | ||||||||||||||||
| OS type for building Yocto: | --- | Type of Regression: | --- | ||||||||||||||
| Verified: | Documentation change: | --- | |||||||||||||||
| Attachments: |
|
||||||||||||||||
Created attachment 913 [details]
out_of_disk_space_log.png
Created attachment 914 [details]
out-of-disk-space-error-message-suggestion.pdf
I think that first this should be implemented in bitbake, and hob should just show the message bitbake sends. There is already built-in functionality to handle this, it just isn't enabled by default, and I'm unsure as to how it shows up within Hob. Cristiana, could you please enable this by setting the BB_DISKMON_DIRS and/or BB_DISKMON_WARNINTERVAL? There is some preliminary documentation here: http://www.yoctoproject.org/docs/latest/poky-ref-manual/poky-ref-manual.html#var-BB_DISKMON_DIRS Ideally we should enable this by default, but we would need to determine what the sensible default values should be. Thank you Paul for information. Belen, I have implemented this, but I have one question. Isn't ok to show also "check the issue..." besides the costum message? Please check no_disk_space.png attachement to understand what I'm saying. Created attachment 942 [details]
no_disk_space
Hi Cristiana, Nice work! :) Yes, I think you are right, although could we change the word 'information' to 'tab' so that the line says: "Check the 'Issues' tab for more details"? It's just more specific about what you need to look at. Other small details to fix: - A single line break for the last sentence looks a bit strange. Could we either add a second line break or eliminate the line break so that the whole message takes a single paragraph? - I think the 'Issues' tab should be selected when this error comes up. That way, I can see the additional information straight away without it being mixed with the build log. - The 3 buttons should be (from left to right): 'Restart the build', 'Edit image' and 'Open log' Thanks!! Belen I think the idea would be to select the "Issues" tab whenever this error comes up. So (In reply to comment #5) > Thank you Paul for information. > > Belen, > I have implemented this, but I have one question. Isn't ok to show also > "check the issue..." besides the costum message? Please check > no_disk_space.png attachement to understand what I'm saying. Patch merged to master. To test this you need a disk full of something and to set the BB_DISKMON_DIRS and/or BB_DISKMON_WARNINTERVAL variables as Paul said. I have opened a bug to have this variables by default in local.conf. Created attachment 956 [details]
blank-disk-full-error.png
Hi Cristiana,
This is working pretty nicely :) We are just missing a '.' at the end of the error message. This is going to sound a bit silly, but it would be nice if we could add it in.
I've also discovered by chance that if BB_DISKMON_VARIABLE is not set in local.conf you get a blank screen (check the attached screenshot blank-disk-full-error.png). I know you've opened a bug to get this variable set in local.conf by default, but probably Hob should not break when it is not set. If the variable is not there or has a different value we should just display a generic build failure message (the one we normally show when a build fails).
What do you want me to do: reopen this bug or open a new one?
Thanks!!
Belen
Hi Belen, Sorry, I don't think I've seen this comment. Andreea from QA showed me. I will work on this one after I will finish the bug I'm working now. Cristiana (In reply to comment #9) > Created attachment 956 [details] > blank-disk-full-error.png > > Hi Cristiana, > > This is working pretty nicely :) We are just missing a '.' at the end of the > error message. This is going to sound a bit silly, but it would be nice if > we could add it in. > > I've also discovered by chance that if BB_DISKMON_VARIABLE is not set in > local.conf you get a blank screen (check the attached screenshot > blank-disk-full-error.png). I know you've opened a bug to get this variable > set in local.conf by default, but probably Hob should not break when it is > not set. If the variable is not there or has a different value we should > just display a generic build failure message (the one we normally show when > a build fails). > > What do you want me to do: reopen this bug or open a new one? > > Thanks!! > > Belen Created attachment 1146 [details]
Screen with var for disk not set
When I have no var for disk set, I don't receive the blank screen. I see the screen as you have an usual error. Please see the attachement. Andreea can you please check it too?
Thanks,
Cristiana
(In reply to comment #11) > Created attachment 1146 [details] > Screen with var for disk not set > > When I have no var for disk set, I don't receive the blank screen. I see the > screen as you have an usual error. Please see the attachement. Andreea can > you please check it too? > > Thanks, > Cristiana Just tested this again, and I didn't get the blank screen either when BB_DISKMON_VARIABLE is not set: I got the standard error. Verified on 92aeb31341b28b193d616ab5cf38af1b9673e37d |
Created attachment 912 [details] out_of_disk_space.png When my build fails due to lack of disk space, Hob just shows me the generic build fail message, which doesn't help me solve the problem (see attached out_of_disk_space.png) Bitbake doesn't help much either: when I look at the log to try to determine what went wrong, I just get a "task do_unpack: Failed" (see attached out_of_disk_space_log.png) Hob should definitely display a special error message when I run out of disk space, so I know what to do to solve the problem. It could be something like what's in the attachment out-of-disk-space-error-message-suggestion.pdf Scott: would you mind reviewing the message text? Thanks!