Bug 3569

I have implemented this design and i have created a branch on poky-contrib with it: http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=cvoicu/sstatemirrors_gtktreeview

In this implementation, you can find a gtk bug. Find more information about it here https://mail.gnome.org/archives/gtk-devel-list/2011-August/msg00050.html

I spoke with Belen, and now I'm waiting her feedback.

Created attachment 1025 [details]
not-editable-cell-styles.png

Hi Cristiana,
 
This is looking really nice. A few little things to look at:

- There is a typo in the 'Configuration' combo box: it should say 'Custom' instead of 'Costum'

- As the design specified, when 'Standard' configuration is selected, the 'Regex' cell is not editable. However, it looks exactly the same as the 'Url' cell, which is editable. I think we need to use a different visual style for that cell when it is not editable. I've attached an example (not-editable-cell-styles.png). In it, I've used a different font colour when the row is not selected, and set the opacity of the font colour to 50% when the row is selected. I have no idea if this can be done or if it's the right approach (as you know, I am not a visual designer). If you already have styles set for inactive controls, maybe we could reuse those. 

- Any chance we could review the spacing between labels and controls in this screen? The space between 'Shared state directory' and the input field seems different to the distance between 'Shared state mirrors' and the GtkTreeView. The space needs to be enough to fit the info icon comfortably. According to the Gnome guidelines, space should come on multiples of 6. 6px might be to small (the info icon might not fit). What about 12px? I am not sure how it's implemented right now, but we can have a chat about it if that helps.

The are also a couple of weird behaviours with the 'Configuration' combo box and the 'Delete mirror' action.
 
- The 'Configuration' combo box one you can see in the attached file weird-configuration-combo-box-behaviour.png. This is how you can reproduce it:
 
1. add a few mirrors (7 or so) until the table scrolls
2. scroll up to the very top of the table and select the top mirror
3. click on the Configuration cell
 
- For the 'Delete mirror' one, this his how you can reproduce it:
 
1. add 7 mirrors or so (enough to make the table scroll)
2. Scroll up to the very top of the table and select the top mirror
3. click the 'Delete mirror' button
 
The table scrolls down to the very bottom, even though the top mirror
is selected after deletion. The scrollbar should stay at the top
so I can see the currently selected mirror
 
I hope this makes sense. Let me know if you have any questions.

Created attachment 1026 [details]
weird-configuration-combo-box-behaviour.png

I have modified the patch according to the advices from Belen, and I have sent it for review.

Merged to master. commit b2ab771447d8d66c1ec43b7d509c1dcfa2e6cec2

Cristiana: this is looking great. There is only one thing that still bugs me: it's the look of the "Regex" cell with the standard configuration when the table row is selected. The font colour is fine, but it looks like there is some sort of effect applied to the font (probably a drop shadow) using a white colour. The result is a bit weird (see attached white-drop-shadow.png).

Could we change the font effect colour to the same grey you are using for the font? 

It's such an small thing that it doesn't seem worth opening a new bug. But I will if you need me to.

Thanks!

Belen

Created attachment 1048 [details]
white-drop-shadow.png

Hi Belen,

I did not notice this thing. In implementing this, I didn't used different colors. In gtk there is a property for cells:  set_property("sensitive", False). It is in charged with this. I think it is better to let it like this, than to do it with colors.
What do you think?
Cristiana


(In reply to comment #6)
> Cristiana: this is looking great. There is only one thing that still bugs
> me: it's the look of the "Regex" cell with the standard configuration when
> the table row is selected. The font colour is fine, but it looks like there
> is some sort of effect applied to the font (probably a drop shadow) using a
> white colour. The result is a bit weird (see attached white-drop-shadow.png).
> 
> Could we change the font effect colour to the same grey you are using for
> the font? 
> 
> It's such an small thing that it doesn't seem worth opening a new bug. But I
> will if you need me to.
> 
> Thanks!
> 
> Belen

I definitely agree. But it seems really strange that the styling of that property comes like that by default. Could we look into this? Sorry I need to insist, but it really looks funny.  

(In reply to comment #8)
> Hi Belen,
> 
> I did not notice this thing. In implementing this, I didn't used different
> colors. In gtk there is a property for cells:  set_property("sensitive",
> False). It is in charged with this. I think it is better to let it like
> this, than to do it with colors.
> What do you think?
> Cristiana
> 
> 
> (In reply to comment #6)
> > Cristiana: this is looking great. There is only one thing that still bugs
> > me: it's the look of the "Regex" cell with the standard configuration when
> > the table row is selected. The font colour is fine, but it looks like there
> > is some sort of effect applied to the font (probably a drop shadow) using a
> > white colour. The result is a bit weird (see attached white-drop-shadow.png).
> > 
> > Could we change the font effect colour to the same grey you are using for
> > the font? 
> > 
> > It's such an small thing that it doesn't seem worth opening a new bug. But I
> > will if you need me to.
> > 
> > Thanks!
> > 
> > Belen

I have investigated a little bit more, and I think there is no way to modify the color for a cell in a treeview after it was selected. I have modified it for all the cells in the column(see the attach pic-it is with red to be more visible for the test), but when it is selected, it is changed.


(In reply to comment #9)
> I definitely agree. But it seems really strange that the styling of that
> property comes like that by default. Could we look into this? Sorry I need
> to insist, but it really looks funny.  
> 
> (In reply to comment #8)
> > Hi Belen,
> > 
> > I did not notice this thing. In implementing this, I didn't used different
> > colors. In gtk there is a property for cells:  set_property("sensitive",
> > False). It is in charged with this. I think it is better to let it like
> > this, than to do it with colors.
> > What do you think?
> > Cristiana
> > 
> > 
> > (In reply to comment #6)
> > > Cristiana: this is looking great. There is only one thing that still bugs
> > > me: it's the look of the "Regex" cell with the standard configuration when
> > > the table row is selected. The font colour is fine, but it looks like there
> > > is some sort of effect applied to the font (probably a drop shadow) using a
> > > white colour. The result is a bit weird (see attached white-drop-shadow.png).
> > > 
> > > Could we change the font effect colour to the same grey you are using for
> > > the font? 
> > > 
> > > It's such an small thing that it doesn't seem worth opening a new bug. But I
> > > will if you need me to.
> > > 
> > > Thanks!
> > > 
> > > Belen

Created attachment 1051 [details]
cell colors

It looks like this is a theme issue, so there is really nothing we can do. Marking as verified (8d80483e2f0f755a61087be1dffaf595fbc467fd)