| Summary: | Recipe parsing warnings should go whenever the machine that generated them is no longer selected | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Build System, Metadata & Runtime] Hob | Reporter: | Belen Barros Pena <belen.barros.pena> | ||||
| Component: | hob | Assignee: | Cristiana Voicu <cristiana.voicu> | ||||
| Status: | VERIFIED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | Medium | CC: | andreea.b.proca, belen.barros.pena, cristian.iorga, poky.bs.watcher, poky.watcher, valentin.popa | ||||
| Version: | unspecified | ||||||
| Target Milestone: | 1.4 | ||||||
| Hardware: | x86 | ||||||
| OS: | Multiple | ||||||
| Whiteboard: | |||||||
| OS type for building Yocto: | --- | Type of Regression: | --- | ||||
| Verified: | Documentation change: | --- | |||||
| Attachments: |
|
||||||
(In reply to comment #0) > Created attachment 1050 [details] > parsing-warning-after-machine-context-gone.png > > Recipe parsing warnings should be closely linked to the machine that prompts > them. If that machine is no longer selected for whatever reason, the infobar > with the warnings should disappear. > > An example you can reproduce: > > 1. Modify a recipe such as you will get a warning during parsing > 2. Launch Hob and select a machine (for example, qemux86) > 3. When recipe parsing finishes, open the Layers dialog > 4. Add a layer (any will do) and click 'Save' > > Outcome: qemux86 is no longer selected, but the recipe parsing warning is > still there. Without the machine selection to provide context, the warning > seems out of place and quite meaningless (see attached > parsing-warning-after-machine-context-gone.png). > > Expected outcome: the warning should no longer be there. > > Note: a different issue is why we should lose the machine selection after > adding a layer. Is there any reason why Hob should behave this way? Adding/removing a layer changes the list of machines. Adding a new layer could add new machines, and removing a layer removes some machines(so it is possible to remove also the selected machine). (In reply to comment #1) > (In reply to comment #0) > > Created attachment 1050 [details] > > parsing-warning-after-machine-context-gone.png > > > > Recipe parsing warnings should be closely linked to the machine that prompts > > them. If that machine is no longer selected for whatever reason, the infobar > > with the warnings should disappear. > > > > An example you can reproduce: > > > > 1. Modify a recipe such as you will get a warning during parsing > > 2. Launch Hob and select a machine (for example, qemux86) > > 3. When recipe parsing finishes, open the Layers dialog > > 4. Add a layer (any will do) and click 'Save' > > > > Outcome: qemux86 is no longer selected, but the recipe parsing warning is > > still there. Without the machine selection to provide context, the warning > > seems out of place and quite meaningless (see attached > > parsing-warning-after-machine-context-gone.png). > > > > Expected outcome: the warning should no longer be there. > > > > Note: a different issue is why we should lose the machine selection after > > adding a layer. Is there any reason why Hob should behave this way? > Adding/removing a layer changes the list of machines. Adding a new layer > could add new machines, and removing a layer removes some machines(so it is > possible to remove also the selected machine). That explains. Thanks! merged to master http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=2c5ad4059ec504f8df481dbcd52210ae91544dbb Hi Cristiana, Warnings have stopped coming up. I am using master c7b23ab68aafc04d9830ef318015912e5d4f0672 Is it just me? Belen Hi Belen, Sorry for the dealy, I forgot about this one. I still have warnings. My test case is the following: I'm changing a line from SRC_URI in meta/recipes-core/eglibc/eglibc_2.17.bb Cristiana (In reply to comment #4) > Hi Cristiana, > > Warnings have stopped coming up. I am using master > c7b23ab68aafc04d9830ef318015912e5d4f0672 > > Is it just me? > > Belen Verified in master:4da406cd50cf02a63ed76810a670aba1eb561c79. Verified. |
Created attachment 1050 [details] parsing-warning-after-machine-context-gone.png Recipe parsing warnings should be closely linked to the machine that prompts them. If that machine is no longer selected for whatever reason, the infobar with the warnings should disappear. An example you can reproduce: 1. Modify a recipe such as you will get a warning during parsing 2. Launch Hob and select a machine (for example, qemux86) 3. When recipe parsing finishes, open the Layers dialog 4. Add a layer (any will do) and click 'Save' Outcome: qemux86 is no longer selected, but the recipe parsing warning is still there. Without the machine selection to provide context, the warning seems out of place and quite meaningless (see attached parsing-warning-after-machine-context-gone.png). Expected outcome: the warning should no longer be there. Note: a different issue is why we should lose the machine selection after adding a layer. Is there any reason why Hob should behave this way?