Bug 4014

Summary: Regarding Licensing of "mbsalign.c" available in util-linux-2.21.2 version (Yocto-1.3-Danny)
Product: [Build System, Metadata & Runtime] OE-Core Reporter: Gaurang Shastri <gmshastri>
Component: coreAssignee: Saul Wold <sgw>
Status: RESOLVED FIXED QA Contact:
Severity: major    
Priority: Medium CC: gmshastri, meta.mr.watcher, meta.watcher, poky.bs.watcher, poky.watcher, sgw
Version: 1.3   
Target Milestone: 1.4 M5   
Hardware: All   
OS: Multiple   
Whiteboard:
OS type for building Yocto: --- Type of Regression: ---
Verified: Documentation change: ---

Description Gaurang Shastri 2013-03-12 05:31:48 UTC 
Hi All,

I have some concerns regarding util-linux-2.21.2 version . As per Yocto-1.3 (danny) recipe,
{{{

LICENSE_${PN}-lscpu = "GPLv3+"  <-- util-linux_2.21.2.bb

LICENSE = "GPLv2+ & LGPLv2.1+ & BSD"   <-- util-linux.inc

}}}

So as per the above description, only lscpu is GPLv3.

But while looking into the source of util-linux-2.21.2, I found out that "util-linux-2.21.2/lib/mbsalign.c" is GPLv3 and it is used by following binaries while building:
{{{
  -  fdisk
  -  partx
}}}

So does it mean that the above binaries should also be GPLv3 and need to take care in util-linux.{bb,inc} ???

Regards,
Gaurang Shastri
Comment 1 Saul Wold 2013-03-15 16:18:26 UTC 
There is a patch pending for the Upstream as well as for both master and danny.


On 03/15/2013 08:12 AM, Karel Zak wrote:
> On Thu, Mar 14, 2013 at 06:49:17PM -0700, Saul Wold wrote:
>> I noticed that you changed the license of lscpu (not so recently),
>
> Yes, all authors of the code agreed with the change.
>
>> I was doing an audit of the util-linux source code and noticed also that the
>> mbsalign.c code was added with GPLv3, it's the only part that is currently
>> GPLv3 in the util-linux code. As you know it's used by cal and lslock.
>>
>> Is there any specific reason that it's marked GPLv3? 
>
> It's originally Pádraig's code (added to CC).
>
> I have personally no problem to change the code to GPLv2 to make the 
> package more consistent and without exceptions.
>
>> Any chance of changing it to be GPLv2? 
>
> Pádraig, any objection? 

Actually LGPLv2+ is most appropriate for that.
The intent is that it's licensed under the LGPL anyway:

$ gnulib/gnulib-tool --local-dir gl --extract-license mbsalign
LGPL

When extracting this to util-linux I should have adjusted
the boilerplate default license in the file (which gnulib-tool
can do on import).

Please apply the attached patch.

thanks,
Pádraig.
Comment 2 Gaurang Shastri 2013-03-18 05:02:54 UTC 
>> Please apply the attached patch.

>> thanks,
>> Pádraig.

Dear Padraig,

Can you attach the patch on this ticket ?

Regards,
Gaurang Shastri