Bug 4069

Summary: ptest files are packaged into core package
Product: [Build System, Metadata & Runtime] OE-Core Reporter: Björn Stenberg <bjst>
Component: deploymentAssignee: Björn Stenberg <bjst>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: Medium+ CC: richard.purdie, sgw
Version: 1.4   
Target Milestone: 1.4 M6   
Hardware: All   
OS: Multiple   
Whiteboard:
OS type for building Yocto: --- Type of Regression: ---
Verified: Documentation change: ---

Description Björn Stenberg 2013-03-21 13:21:07 UTC 
(copied from oe-core list email 20130320083055.GQ31812@sestofb10.enea.se)

The ${PN}-ptest group is not added to PACKAGES by default in bitbake.conf like
all the other groups. Instead it is added to PACKAGES in ptest.bbclass. This way
it is only added for those recipes that implement ptest.

However it turns out this doesn't work when package splitting. Instead of
putting ptest files into packages-split/${PN}-ptest, those files are put into
the core ${PN} package which is obviously not what we want.

I'm scratching my head a bit about why this happens, and would like help from
people with deeper bitbake knowledge. I guess the splitting is somehow done
outside the package scope, but why and how do we fix it?

Putting ${PN}-ptest in PACKAGES in bitbake.conf "solves" this issue, but Richard
Purdie was against that earlier since we yet have only a few "ptest enabled"
packages.

# find tmp/work/i586-poky-linux/bash -name run-ptest
tmp/work/i586-poky-linux/bash/4.2-r6/image/usr/lib/bash/ptest/run-ptest
tmp/work/i586-poky-linux/bash/4.2-r6/sysroot-destdir/usr/lib/bash/ptest/run-ptest
tmp/work/i586-poky-linux/bash/4.2-r6/package/usr/lib/bash/ptest/run-ptest
tmp/work/i586-poky-linux/bash/4.2-r6/run-ptest
tmp/work/i586-poky-linux/bash/4.2-r6/packages-split/bash/usr/lib/bash/ptest/run-ptest

We want is the last line to be:

tmp/work/i586-poky-linux/bash/4.2-r6/packages-split/bash-ptest/usr/lib/bash/ptest/run-ptest
Comment 1 Björn Stenberg 2013-03-21 14:53:12 UTC 
Aha, this is caused by ptest.bbclass doing:

  PACKAGES += "${PN}-ptest"

instead of:

  PACKAGES =+ "${PN}-ptest"

Unfortunately, the full solution is not quite that simple. But now I know enough to submit a patch.
Comment 2 Saul Wold 2013-03-21 15:42:14 UTC 
Bjorn, I was just going to look at that this morning, looks like you found the trick, which is the PACKAGES list is greedy by nature, meaning things earlier in the list will match and remove them from consideration by packages later in the list.

I guess I can close this bug then?
Comment 3 Björn Stenberg 2013-03-21 15:50:46 UTC 
Yes, I just sent a patch with a proposed solution for this.

Re: closing: Do we close bugs when a fix is found or when a fix is accepted?
Comment 4 Saul Wold 2013-03-21 16:59:02 UTC 
Right, I will assign this back to you and you can mark it resolved when the patch is accepted, since this is a bug.  I will pull this into MUT and queue it once we get M5 built.
Comment 5 Richard Purdie 2013-04-11 11:46:50 UTC 
Patch was taken into master (http://git.yoctoproject.org/cgit.cgi/poky/commit/?id=44120a053c0cf2c7134bb1ee29854dddf28e4cf8). Please open new bugs for any further issues.