Bug 4636

Summary: Hob should make sure comments are added on the next line
Product: [Build System, Metadata & Runtime] Hob Reporter: Stoicescu Cornel <corneliux.stoicescu>
Component: hobAssignee: Cristiana Voicu <cristiana.voicu>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: Medium CC: belen.barros.pena, cristian.iorga, poky.bs.watcher, poky.watcher, valentin.popa
Version: 1.5   
Target Milestone: 1.5   
Hardware: x86   
OS: Multiple   
Whiteboard:
OS type for building Yocto: --- Type of Regression: ---
Verified: Documentation change: ---

Description Stoicescu Cornel 2013-06-11 12:47:27 UTC
1) clone poky
2) checkout master:a62aed41f2d8f874f7ae24d0e5be5dbc66ea2199
3) source oe-init-build-env
4) edit local.conf and add a new line of configuration (ex: LICENSE_FLAGS_WHITELIST = "license_emgd-driver-bin")
NOTE: -use a text editor that does not add "\n" as default last character (ex: mc)
      -make sure the last character of the file is on the quotation mark from the above line
5) launch hob
6) add a new layer
Notice parse error (see bug 4635 ). It says bitbake cannot parse LICENSE_FLAGS_WHITELIST = "license_emgd-driver-bin"#added by bitbake

7) close hob and open local.conf
Notice that HOB added the comment inline with the last statement while all other such comments are on a new line:

LICENSE_FLAGS_WHITELIST = "license_emgd-driver-bin"#added by bitbake
DL_DIR = "/home/lserban/work/poky/build/downloads"
#added by bitbake
SSTATE_DIR = "/home/lserban/work/poky/build/sstate-cache"
#added by bitbake
SSTATE_MIRRORS = ""

Expected outcome:
1) HOB should add all "#added by bitbake" comments the same way, on a new line
2) If the above expectation is not valid, it should add comments according to the resolution of bug 4635 so that it will not give off parse errors.
Comment 2 Stoicescu Cornel 2013-06-27 11:39:00 UTC
Verified in master:4852c4f6a109e64a0b3e342db733eb588389afcc