Bug 4752

Summary: Some QA errors no longer enabled
Product: [Build System, Metadata & Runtime] OE-Core Reporter: Paul Eggleton <bluelightning>
Component: configurationAssignee: Paul Eggleton <bluelightning>
Status: VERIFIED FIXED QA Contact:
Severity: major    
Priority: High CC: alexandrux.palalau, jessica.zhang, kergoth
Version: 1.5   
Target Milestone: 1.5 M2   
Hardware: All   
OS: Multiple   
Whiteboard:
OS type for building Yocto: --- Type of Regression: Regression (Used to work)
Verified: Documentation change: Don't know

Description Paul Eggleton 2013-06-19 16:01:18 UTC 
A recent change in master disabled QA errors for checks not mentioned in ERROR_QA or WARN_QA:

http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=d4a7820eee932c9796920e9453be68f9b7eb8ade

Unfortunately this has caused regressions with the default OE-Core and Poky values for these variables, e.g. "installed-vs-shipped" is not in ERROR_QA so this error will no longer be shown.

To fix this, we need to:

1) Determine if any QA checks other than "installed-vs-shipped" have also been turned off as a result of this change

2) Fix the ERROR_QA value in OE-Core

3) Fix the ERROR_QA value in Poky
Comment 1 Paul Eggleton 2013-06-19 16:02:16 UTC 
We'll also need to mention this in the migration notes for 1.5 as users may have set their own values for these variables.
Comment 2 Paul Eggleton 2013-06-28 15:21:26 UTC 
It turns out that OE-Core's default ERROR_QA and WARN_QA (from insane.bbclass) were fine here, it was just poky.conf that didn't mention a number of the checks in its values. A patch has been sent for review to add these back additionally with a lean towards making them errors rather than warnings.
Comment 3 Paul Eggleton 2013-06-28 15:25:57 UTC 
For reference, the list of QA checks that were affected by this issue:

already-stripped
compile-host-path
dep-cmp
files-invalid
incompatible-license
installed-vs-shipped
install-host-path
libdir
packages-list
perm-config
perm-line
perm-link
pkgv-undefined
pn-overrides
split-strip
var-undefined
xorg-driver-abi
Comment 4 Christopher Larson 2013-06-28 15:28:33 UTC 
That's a relief, thanks for looking into this, and sorry about the hassle.
Comment 5 Paul Eggleton 2013-06-28 15:44:42 UTC 
No problem. The silver lining is that some of these were defined as errors in OE-Core but were being treated as warnings in Poky so we had an undiscovered inconsistency already; also, I found that a bunch of the checks aren't documented in the reference manual section on insane.bbclass (I have added bug 4788 to fix the latter).
Comment 7 Alexandru Palalau 2013-10-01 14:17:36 UTC 
Swithing to verified.
Commit ID: a1d9b6df86b0829d591cae57ae351f6d96e63557