Bug 4837

Summary:	busybox syslog has two different configuration files depending on the init system
Product:	[Build System, Metadata & Runtime] OE-Core	Reporter:	Holger Freyther <holger>
Component:	core	Assignee:	Chen Qi <Qi.Chen>
Status:	VERIFIED FIXED	QA Contact:
Severity:	enhancement
Priority:	Medium	CC:	ke.zou, liezhi.yang, mark.hatle, meta.mr.watcher, meta.watcher, yi.zhao
Version:	unspecified
Target Milestone:	1.5 M4
Hardware:	x86
OS:	Multiple
Whiteboard:
OS type for building Yocto:	---	Type of Regression:	---
Verified:		Documentation change:	Don't know

Description Holger Freyther 2013-07-10 09:03:25 UTC

busybox currently has two different ways to configure it and on the surface it would appear that both could be shared.

For sysvinit the /etc/syslog-startup.conf file is sourced by the init script and then the SYSLOG_ARGS is built. For systemd the /etc/default/busybox-syslog file is parsed and $OPTIONS will be used.

It should be possible to do the following:
* Move the SYSLOG_ARGS of the init script to /etc/default/busybox-syslog
* Use SYSLOG_ARGS in the busybox-syslog.service.in file

The benefit:
* It is less confusing why two configuration files (one documented but unused, one empty but used).

Comment 1 Chen Qi 2013-07-17 15:37:48 UTC

I think we should respect the configuration in /etc/syslog-startup.conf.

Besides, as the /etc/init.d/syslog.busybox parses /etc/syslog-startup.conf and gets SYSLOG_ARGS, I think we could make use of this script.

A related bug is https://bugzilla.yoctoproject.org/show_bug.cgi?id=4860.

That's actually a weekly test case.

//Chen Qi

Comment 2 Chen Qi 2013-07-22 08:10:23 UTC

As Ross replied on the mailing list, "there's work on-going to make the init classes delete scripts that are installed as appropriate". I'll wait until that work is done.

//Chen Qi

Comment 3 Chen Qi 2013-08-07 08:45:17 UTC

sysvinit and systemd have different ideas about configuration files (or environment files in systemd), so using the same one for both is not appropriate.

Remove the 'syslog-startup.conf' file if 'sysvinit' is not in DISTRO_FEATURES.

//Chen Qi

Comment 4 Chen Qi 2013-08-13 05:23:08 UTC

merged into poky/master

Commit: 89f62147a61108b4be40001e1fbe3be33bacf00b
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=89f62147a61108b4be40001e1fbe3be33bacf00b

Comment 5 Ke Zou 2013-11-08 06:37:03 UTC

verified with YOCTO #4860

https://bugzilla.yoctoproject.org/show_bug.cgi?id=4860