Bug 4840

The patches for feature #4193 are not yet merged to master, and this enhancement depends on them. I will move this feature to M4.

Hi Belen,

For this feature we will need a design. Can you help me with this?
Thanks,
Cristiana

I'll start working on that.

(In reply to comment #2)
> Hi Belen,
> 
> For this feature we will need a design. Can you help me with this?
> Thanks,
> Cristiana

Created attachment 1378 [details]
Deleting and editing custom image recipes

Hi Cristiana,

Design document attached. Let me know what you think.

Hi Belen,

It looks good. I see that you have made a design for editing. I think this should be addressed in another enhancement. Can you please split it?
Also I have a concern regarding the place of the ADT target. This will be next to templates right? If yes, I think the top of this page will be crowded. What do you think?

Thanks,
Cristiana 

(In reply to comment #4)
> Created attachment 1378 [details]
> Deleting and editing custom image recipes
> 
> Hi Cristiana,
> 
> Design document attached. Let me know what you think.

(In reply to comment #5)
> Hi Belen,
> 
> It looks good. I see that you have made a design for editing. I think this
> should be addressed in another enhancement. Can you please split it?

Done! https://bugzilla.yoctoproject.org/show_bug.cgi?id=4944

> Also I have a concern regarding the place of the ADT target. This will be
> next to templates right? If yes, I think the top of this page will be
> crowded. What do you think?

We'll have 4 buttons there (the ADT one will be the first from the left). I think it's probably ok (plenty of space for the moment), but you are right: we should be careful from now on.

> 
> Thanks,
> Cristiana 
> 
> (In reply to comment #4)
> > Created attachment 1378 [details]
> > Deleting and editing custom image recipes
> > 
> > Hi Cristiana,
> > 
> > Design document attached. Let me know what you think.

Created attachment 1381 [details]
Deleting custom image recipes

Setting the milestone to future after conversation with Cristiana, PaulE and RP

Created attachment 1767 [details]
contains 4 commits

I added a patch with the work I've done so far. It contains 4 commits and a big part of the interface is done. 

I worked on top of the commit: 1a9226f140f578f11696abf1a3c989fae1d4c14a . I hope there won't be too many merge conflicts in the future.

I have also added the partial work on a poky contrib branch: 
http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=mavram/Bug4840

(In reply to comment #10)
> I have also added the partial work on a poky contrib branch: 
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=mavram/Bug4840

Hi Marius, when I try to run Hob using this branch, I get the following error:

yocto@icarus:~/poky/build$ hob
Traceback (most recent call last):
  File "/home/yocto/poky/bitbake/bin/bitbake", line 352, in <module>
    ret = main()
  File "/home/yocto/poky/bitbake/bin/bitbake", line 248, in main
    ui_module = get_ui(configParams)
  File "/home/yocto/poky/bitbake/bin/bitbake", line 72, in get_ui
    module = __import__("bb.ui", fromlist = [interface])
  File "/home/yocto/poky/bitbake/lib/bb/ui/hob.py", line 47, in <module>
    from bb.ui.crumbs.builder import Builder
  File "/home/yocto/poky/bitbake/lib/bb/ui/crumbs/builder.py", line 50, in <module>
    from bb.ui.crumbs.hig.imagerecipesdialog import ImageRecipesDialog
  File "/home/yocto/poky/bitbake/lib/bb/ui/crumbs/hig/imagerecipesdialog.py", line 38
    self.vbox.pack_start(label)
       ^
SyntaxError: invalid syntax

Any ideas of what I am doing wrong?

Thanks!

I added a fix. Sorry about that and for my delayed answer. It was just a missing parentheses in the code.

Same branch as before:
http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=mavram/Bug4840

To view the no results bar type in the search box "No result".
Anyway, I must recall you that this is yet incomplete work because it was put on hold.

At this point, work will take place on toaster, not hob, so marking as won't fix.