Bug 5068

Summary:	[webhob-poky/master]The interruption of a building does not have the expected behavior.
Product:	[Build System, Metadata & Runtime] Toaster	Reporter:	Andreea Brandusa Proca <andreea.b.proca>
Component:	toaster	Assignee:	Alexandru Damian <alexandru.damian>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	Medium+	CC:	belen.barros.pena
Version:	unspecified
Target Milestone:	1.6 M1
Hardware:	x86
OS:	Multiple
Whiteboard:	bitbake
OS type for building Yocto:	---	Type of Regression:	---
Verified:		Documentation change:	No (bug/feature does not impact docs)

Description Andreea Brandusa Proca 2013-08-29 07:01:01 UTC

Steps to reproduce:
1. build core-image-sato
2. press CTR+C

The outcome has the value "In progress" for a while and then it changes to "Succeeded".


Even if:

brandusa@andreea-Vostro-460:~/poky-contrib/build$ ps aux | grep bitbake
brandusa  2540  0.0  0.2  61888 16372 pts/10   S    21:31   0:00 python /home/brandusa/poky-contrib/bitbake/bin/../lib/webhob/manage.py runserver
brandusa  2542  0.5  0.2 361008 23904 pts/10   Sl   21:31   0:00 /usr/bin/python /home/brandusa/poky-contrib/bitbake/bin/../lib/webhob/manage.py runserver
brandusa  2549  110  1.9 409704 162800 ?       Sl   21:31   2:50 python /home/brandusa/poky-contrib/bitbake/bin/bitbake --server-only -t xmlrpc -B localhost:8200
brandusa  2551 28.5  0.8 184996 66864 pts/10   Sl   21:31   0:43 python /home/brandusa/poky-contrib/bitbake/bin/bitbake --observe-only -u dsi
brandusa  2648 28.6  0.2 153544 20072 pts/10   Sl+  21:33   0:09 python /home/brandusa/poky-contrib/bitbake/bin/bitbake core-image-sato
brandusa  2768  0.0  0.0  13584   920 pts/6    S+   21:33   0:00 grep --color=auto bitbake

brandusa@andreea-Vostro-460:~/poky-contrib/build$ ps aux | grep bitbake
brandusa  2540  0.0  0.2  61888 16372 pts/10   S    21:31   0:00 python /home/brandusa/poky-contrib/bitbake/bin/../lib/webhob/manage.py runserver
brandusa  2542  0.5  0.2 361008 23904 pts/10   Sl   21:31   0:01 /usr/bin/python /home/brandusa/poky-contrib/bitbake/bin/../lib/webhob/manage.py runserver
brandusa  2549  112  2.5 475240 208904 ?       Rl   21:31   5:26 python /home/brandusa/poky-contrib/bitbake/bin/bitbake --server-only -t xmlrpc -B localhost:8200
brandusa  2551 28.4  1.3 188136 108224 pts/10  Sl   21:31   1:22 python /home/brandusa/poky-contrib/bitbake/bin/bitbake --observe-only -u dsi
brandusa  2770  0.0  0.0  13584   916 pts/6    S+   21:36   0:00 grep --color=auto bitbake

Comment 1 Belen Barros Pena 2013-08-29 09:52:26 UTC

Any build that doesn't complete should be reported as failed, including interrupted builds.

Hopefully BitBake will provide some kind of message that will tell users the reason of the fail (i.e. this build was interrupted).

Comment 2 Alexandru Damian 2013-09-19 17:02:48 UTC

Fixed in webhob-poky/master-1_5-1909

Comment 3 Andreea Brandusa Proca 2013-09-26 14:39:31 UTC

In webhob-poky/webhob-master-1_5-2009 the problem is not solved. The outcome is "Succeeded".

Comment 4 Alexandru Damian 2013-09-26 15:54:58 UTC

This is what bitbake reports, and what I think should happen -

If the build is manually stopped, the user wittingly sent the stop command, and the system is in an 'OK' state.

Failures happen only on errors.

Comment 5 Belen Barros Pena 2013-09-26 16:17:53 UTC

(In reply to comment #4)
> This is what bitbake reports, and what I think should happen -
> 
> If the build is manually stopped, the user wittingly sent the stop command,
> and the system is in an 'OK' state.

The system is in an OK state, but the outcome is about the build, not the build system. 

An interrupted build is not a successful build. 

> 
> Failures happen only on errors.

A successful build is a build that completes without errors. An interrupted build did not complete, so it does not pass the first criteria of a successful build.

I think we have 2 options:

1. We create an 'interrupted' outcome
2. We use the existing outcome that most closely reflects the situation with the build itself, which it's probably 'failed'

Comment 6 Alexandru Damian 2013-11-19 16:47:19 UTC

patch on bitbake-devel mailing list

Comment 7 Belen Barros Pena 2013-12-23 10:51:02 UTC

merged to master. Interrupted build outcome is now "Failed" with an "Stopped build" error, which is good.

Comment 8 Belen Barros Pena 2013-12-23 10:51:28 UTC

Verified in master:3ada51f7aa26fc95d5f9ba4498c0ea54acc6e42e