Bug 5117

Summary: generic-x86-64 image does not recover display after standby
Product: [Build System, Metadata & Runtime] BSPs Reporter: Stoicescu Cornel <corneliux.stoicescu>
Component: bsps-runtimeAssignee: Nitin Kamble <nitin.a.kamble>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: Medium CC: dvhart, razvanx.ionescu, ross.burton, yp.kernel.watcher, yp.watcher
Version: 1.5   
Target Milestone: 1.5 M5   
Hardware: x86   
OS: Multiple   
Whiteboard:
OS type for building Yocto: --- Type of Regression: ---
Verified: Documentation change: Don't know
Attachments:
Description Flags
dmesg log for generic image none

Description Stoicescu Cornel 2013-09-04 11:49:15 UTC 
STATUS: FAILED
BUILD: master:5745e45b18e5099e94b4d5a73bc97dc6d4cdc91f
ENVIRONMENT: tested on Sugarbay hardware
STEPS TO REPRODUCE: 
1. boot system and launch terminal
2. echo "mem" > /sys/power/state
3. After system go into S3 mode, press power button to make it resume
5. Check if applications can work as normal.

EXPECTED OUTCOME: Screen should resume and applications should work.

ACTUAL RESULT: Screen does not resume. It remains in standby.

NOTE: Work is still possible over ssh without issues.
Comment 1 Ross Burton 2013-09-04 12:13:48 UTC 
Does this work correctly in other BSPs?
Comment 2 Stoicescu Cornel 2013-09-04 12:26:47 UTC 
According to test results for 1.5 M4 RC2, standby works correctly on other BSP. I will test it again using core-image-sato-sdk-sugarbay .
Comment 3 Stoicescu Cornel 2013-09-04 12:40:11 UTC 
I can confirm standby is working correctly on same hardware using core-image-sato-sdk-sugarbay image.
Comment 4 Stoicescu Cornel 2013-09-04 13:37:12 UTC 
Created attachment 1460 [details]
dmesg log for generic image
Comment 5 Stoicescu Cornel 2013-09-04 13:38:04 UTC 
genericx86-64 image resumes from standby correctly on Jasperforest hardware.
Comment 6 Nitin Kamble 2013-09-19 22:24:53 UTC 
I am able to reproduce the issue locally here. The suberbay BSP is able to resume well after suspend, but the genricx86-64 is not.  I also see some key differences in the kernel config. I am digging further to find a solution here.

Thanks,
Nitin
Comment 7 Nitin Kamble 2013-09-23 21:39:30 UTC 
update:
I tried adding missing kernel config options for the genericx86 BSP. But the X on screen is garbage with these changes.
Comment 8 Nitin Kamble 2013-09-24 18:27:26 UTC 
With lot of experimentation, and testing finally I have found the set of kernel configurations needed to get the resume working. The fix is sent to linux-yocto ML, and is open for review now.
Comment 9 Nitin Kamble 2013-10-02 20:09:32 UTC 
Fixed in the kernel commit:
commit dad2b7e1ceed654fba89907f3e14050007699b90
Author: Nitin A Kamble <nitin.a.kamble@intel.com>
Date:   Tue Sep 24 18:13:27 2013 +0000

    common-pc-64: add kernel CONFIG options for sugarbay platform
    
    Add these Kernel driver config options for Sugarbay platform.
    
    - i915 graphics
    - 8250 serial port
    - usb webcam drivers
    - generic power management support to enable proper suspend/resume
    
    Fixes Bug:
    [YOCTO #5117]
    
    Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
Comment 10 Nitin Kamble 2013-10-02 20:16:12 UTC 
This is the oecore commit pull in the kernel fixes:

commit 41875facc982f1c96a5ddf275adba1634b1a5ced
Author: Bruce Ashfield <bruce.ashfield@windriver.com>
Date:   Wed Sep 25 15:30:12 2013 -0400

    linux-yocto/3.10: common-pc* config updates
    
    Bumping the 3.10 meta branch SRCREV to import the following config changes
    for tghe sugarbay and common-pc wifi fragments.
    
       dad2b7e common-pc-64: add kernel CONFIG options for sugarbay platform
       37c617d common-pc-wifi.cfg: add support for broadcom wifi drivers
    
    [YOCTO #5117]
    [YOCTO #5238]
    
    (From OE-Core rev: 180f465b0cab13e17dc92ac5c88d7d9001cd5b11)
    
    Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
    Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>
    Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Comment 11 Razvan Ionescu 2013-10-03 11:24:02 UTC 
Tested and verified with: dora:a02280f99f05b1c21de2a78de9222a2f62a0dabc (1.5 M5 RC6) which includes the fixing commit.
Image generic_x86-64 on sugarbay.